Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pattern from serverSetting. to querySetting for consistency #13

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

mkaufmann
Copy link
Member

Server Settings are easy to be confused with global system-wide settings while users only have the mean to rename connection settings. In V3 Connect API the concept of query level settings is called "querySettings", thus we propose the same name in JDBC. We still accept the old name for transition purposes but will log a warning message.

Drive-By:

  • Factor our the test Hyper Server Process management into separate class for clarity
  • Improve shutdown speed by using waitFor instead of fixed 3s sleep
  • Be strict on config settings as previously we had a silently a setting that hyper wouldn't recognize
  • Use auto port picking for the server process to avoid accidental colissions
  • Be consciously less robust on server process management during test to make any failures and problems very explicitly

Copy link

salesforce-cla bot commented Feb 5, 2025

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Moritz Kaufmann <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Server Settings are easy to be confused with global system-wide settings while users only have the mean to rename connection settings.
In V3 Connect API the concept of query level settings is called "querySettings", thus we propose the same name in JDBC.
 We still accept the old name for transition purposes but will log a warning message.

Drive-By:
 - Factor our the test Hyper Server Process management into separate class for clarity
 - Improve shutdown speed by using waitFor instead of fixed 3s sleep
 - Be strict on config settings as previously we had a silently a setting that hyper wouldn't recognize
 - Use auto port picking for the server process to avoid accidental colissions
 - Be consciously less robust on server process management during test to make any failures and problems very explicitly
@mkaufmann mkaufmann force-pushed the mkaufmann-query-settings branch from e9b2aca to d9c80ee Compare February 5, 2025 21:49
jschneidereit
jschneidereit previously approved these changes Feb 5, 2025
@geoffrothman
Copy link
Contributor

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Moritz Kaufmann <m***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

loser!! :) j/k I just got mine to work

@mkaufmann mkaufmann merged commit 933226a into forcedotcom:main Feb 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants