Skip to content

Commit

Permalink
test: remove more skips
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Oct 11, 2023
1 parent 13dd085 commit 469373f
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions test/unit/org/authInfoTest.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ describe('AuthInfo', () => {
expect(authInfo.getSfdxAuthUrl()).to.contain(`force://PlatformCLI::${testOrg.refreshToken}@${instanceUrl}`);
});

it.skip('should handle undefined refresh token', async () => {
it('should handle undefined refresh token', async () => {
const authResponse = {
access_token: testOrg.accessToken,
instance_url: testOrg.instanceUrl,
Expand All @@ -1292,12 +1292,11 @@ describe('AuthInfo', () => {
});

// delete the refresh token
delete authInfo.getFields().refreshToken;

authInfo.update({ ...authInfo.getFields(), refreshToken: undefined });
expect(() => authInfo.getSfdxAuthUrl()).to.throw('undefined refreshToken');
});

it.skip('should handle undefined instance url', async () => {
it('should handle undefined instance url', async () => {
const authResponse = {
access_token: testOrg.accessToken,
instance_url: testOrg.instanceUrl,
Expand All @@ -1317,7 +1316,7 @@ describe('AuthInfo', () => {
});

// delete the instance url
delete authInfo.getFields().instanceUrl;
authInfo.update({ ...authInfo.getFields(), instanceUrl: undefined });

expect(() => authInfo.getSfdxAuthUrl()).to.throw('undefined instanceUrl');
});
Expand Down

2 comments on commit 469373f

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 469373f Previous: 8e346ca Ratio
Child logger creation 440373 ops/sec (±0.96%) 530040 ops/sec (±0.21%) 1.20
Logging a string on root logger 373009 ops/sec (±11.79%) 493295 ops/sec (±10.24%) 1.32
Logging an object on root logger 227600 ops/sec (±15.53%) 351593 ops/sec (±20.62%) 1.54
Logging an object with a message on root logger 167706 ops/sec (±23.20%) 212392 ops/sec (±13.57%) 1.27
Logging an object with a redacted prop on root logger 148543 ops/sec (±24.92%) 13921 ops/sec (±186.34%) 0.09371697084345947
Logging a nested 3-level object on root logger 116594 ops/sec (±24.07%) 210216 ops/sec (±13.97%) 1.80

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 469373f Previous: 8e346ca Ratio
Child logger creation 480185 ops/sec (±7.93%) 354069 ops/sec (±11.38%) 0.74
Logging a string on root logger 550872 ops/sec (±9.13%) 417103 ops/sec (±9.66%) 0.76
Logging an object on root logger 304616 ops/sec (±21.01%) 305300 ops/sec (±18.95%) 1.00
Logging an object with a message on root logger 150339 ops/sec (±27.34%) 212172 ops/sec (±13.30%) 1.41
Logging an object with a redacted prop on root logger 180772 ops/sec (±20.15%) 233725 ops/sec (±21.69%) 1.29
Logging a nested 3-level object on root logger 117672 ops/sec (±22.59%) 187343 ops/sec (±21.04%) 1.59

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.