Sm/review qa read unlock #1121
Merged
Sm/review qa read unlock #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add a NUT (QA for the PR). There originally was a concurrency test but it wasn't running because it used the wrong naming convention (unique to this repo).
refactor from pollingClient => direct use of ts-retry-promise library
@mdonnalley I didn't have to increase retries for the NUT's approach (parallel'd child_process) the way the original concurrency test required (child_process.exec probably gives enough delay to spread them a bit).
[skip validate pr]
I ran the nut locally with
100, but left the committed version as50