✨🐛 Pass on non-threshold detector parameters #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
mdevino
suggested changes
Oct 22, 2024
Co-authored-by: Mateus Devino <[email protected]> Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
Signed-off-by: Evaline Ju <[email protected]>
resoluteCoder
pushed a commit
to resoluteCoder/fms-guardrails-orchestrator
that referenced
this pull request
Nov 4, 2024
) * ✨ Pass along detector_params for text contents and generation Signed-off-by: Evaline Ju <[email protected]> * ✨✅ Not pass on threshold param Signed-off-by: Evaline Ju <[email protected]> * 🐛 Mutable threshold not intuitive Signed-off-by: Evaline Ju <[email protected]> * Update src/clients/detector/text_chat.rs Co-authored-by: Mateus Devino <[email protected]> Signed-off-by: Evaline Ju <[email protected]> * 💡🎨 Update params comment and remove unnecessary clones Signed-off-by: Evaline Ju <[email protected]> * ✅ Threshold re-call not problematic Signed-off-by: Evaline Ju <[email protected]> --------- Signed-off-by: Evaline Ju <[email protected]> Co-authored-by: Mateus Devino <[email protected]> Signed-off-by: resoluteCoder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detector_paramsto additional detectors API endpoints (/text/contentsand/text/generation) as documented through 🔧 Add detector_params as optional for every detectors endpoint #212thresholdin the orchestrator, so we do not want to pass this on to the detectors. This is currently just removed. This now builds off 🐛 Fix threshold getting passed through beyond orchestrator proces… #236 which assumespop_thresholdwill only be done once per detector flowCloses: #227 , #234