🐛 Fix threshold getting passed through beyond orchestrator proces… #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gkumbhat <[email protected]>
evaline-ju
reviewed
Oct 22, 2024
| assert_eq!(value.threshold(), Some(0.2)); | ||
| let value = DetectorParams::new(); | ||
| assert!(!value.contains_key("threshold")); |
There was a problem hiding this comment.
I did this for the first iteration of #235 but felt it was not intuitive since essentially if value.threshold() were to get called again for this same value, the result would change. This could get confusing if any function happens to call threshold() twice
Signed-off-by: gkumbhat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
thresholdparameter as soon as it gets fetched.Closes: #234