Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release workflows #193

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Add release workflows #193

merged 3 commits into from
Feb 7, 2025

Conversation

amacneil
Copy link
Contributor

@amacneil amacneil commented Feb 6, 2025 •
edited
Loading

Changelog

None

Docs

None

Description

New release workflows:

  • Draft release workflow to bump version number across all SDK packages (rust + python) and draft release notes
  • Post release workflow to merge release tag back into main branch

@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch 2 times, most recently from 3118a47 to 7634e49 Compare February 6, 2025 22:30
@foxglove foxglove deleted a comment from linear bot Feb 6, 2025
@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch 16 times, most recently from 73b2ad3 to 8834c71 Compare February 7, 2025 05:53
@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch from 8834c71 to 17926f9 Compare February 7, 2025 05:54
@amacneil amacneil marked this pull request as ready for review February 7, 2025 05:56
@amacneil amacneil requested review from gasmith and bryfox February 7, 2025 05:56
bryfox
bryfox approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@bryfox bryfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions, but looks good to me. I'm not sure what the release note generation does, but that's easy enough to adjust.

.github/workflows/post-release.yml Outdated
- uses: actions/checkout@v4
with:
ref: ${{ env.SDK_TAG }}
fetch-depth: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I'm not seeing why we need the full history

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this workflow I didn't test without it, but assumed I need this since we git checkout main which may have diverged from the release branch/tag. I'll add a comment as such.

@amacneil amacneil changed the title Draft release workflow Add release workflows Feb 7, 2025
@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch from e58f686 to 14158ce Compare February 7, 2025 14:55
@amacneil
Copy link
Contributor Author

amacneil commented Feb 7, 2025

I'm not sure what the release note generation does

It just adds the default github-generated release notes. We need to specify the correct tag though since we are still releasing other packages from this repo, so the most recent tag might not necessarily be an SDK one.

@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch from 14158ce to 962c558 Compare February 7, 2025 15:00
@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch from 53df8e3 to 4f597f7 Compare February 7, 2025 15:11
@amacneil amacneil force-pushed the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch from 4f597f7 to fc29675 Compare February 7, 2025 15:12
amacneil
amacneil commented Feb 7, 2025
View reviewed changes
.npmignore
@@ -1 +0,0 @@
ros_foxglove_msgs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to PR but this file is no longer needed as of #170

amacneil
amacneil commented Feb 7, 2025
View reviewed changes
python/foxglove-sdk/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "foxglove-sdk-python"
version = "0.1.0"
version = "0.1.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping for consistency with rust package

@amacneil amacneil merged commit 1df7e3d into main Feb 7, 2025
27 checks passed
@amacneil amacneil deleted the adrian/fg-10372-consider-versioning-sdk-across-all-languages branch February 7, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryfox bryfox bryfox approved these changes

@gasmith gasmith Awaiting requested review from gasmith

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amacneil @bryfox