Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed batch naming to be a slug of the title #1255

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Jan 17, 2025

Previously, batch names were in the format of CLS-####. This was not URL-friendly. This PR changes the batch name to a slug. For example, if a batch's title is Framework March 2025, then the batch's name would be framework-march-2025. This would give some context of the batch when the URL is shared.

Screenshot 2025-01-17 at 10 39 53 AM

Closes #733

Copy link

cypress bot commented Jan 17, 2025

lms    Run #987

Run Properties:  status check passed Passed #987  •  git commit b315d466f9 ℹ️: Merge 9d1211e872e46afca861db63b2156298b792124c into 215ae941e198871a760e3ba56860...
Project lms
Branch Review batch-url
Run status status check passed Passed #987
Run duration 00m 29s
Commit git commit b315d466f9 ℹ️: Merge 9d1211e872e46afca861db63b2156298b792124c into 215ae941e198871a760e3ba56860...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 34685eb into frappe:develop Jan 17, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrubbed batch title in routes
2 participants