ipasudorule: Add support for batch mode and multiple sudorules

[rjeffman]

Currently, ipasudorule must add or modify a single sudorule at a time, incurring in more load in the server if there are many rules to be processed.

This patch adds suport for adding multiple sudorules in one playbook task by using the parameter 'sudorules' and defining a list of sudorules configurations to be ensured.

As multiple sudorules will be processed, the patch also enables batch mode processing of sudorules, trying to reduce the load on the server.

To be able to process parameter values in the 'sudorules' dictionary, the method to retrieve parameters from the module in lowercase was refactored, allowing any parameter value, either from the module or from a dict, to be converted.

Test 'tests/sudorule/test_sudorule_client_context.yml' was modified to include tasks with 'sudorules' to be executed both on the server or on the client context.

New tests were added to the sudorule test suite:

tests/sudorule/test_sudorules.yml
tests/sudorule/test_sudorules_member_case_insensitive.yml

[varunmylaraiah]

@rjeffman Is it possible to add multiple sudorules using a JSON file?

[rjeffman]

@varunmylaraiah it should be, as this is handled by Ansible before ansible-freeipa kicks in.

[rjeffman]

/azp run CheckPR

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rjeffman]

The pydocstyle check is failing due to a false positive, please, see PR #1310.

[varunmylaraiah]

Hi Rafael, I'm seeing an error and not sure what I might be missing here

# cat sudo1.yaml 
---
- name: Playbook to ensure a sudorule is present.
  hosts: ipaserver
  become: true

  tasks:
  - name: Test multiple sudo rules
    ipasudorule:
      ipaadmin_password: <xxxxxxx>
      sudorules:
        - name: sudorule1
        - name: sudorule2
        - name: sudorule3
      state: present

PLAY [Playbook to ensure a sudorule is present.] *******************************************************

TASK [Gathering Facts] *********************************************************************************
task path: /root/sudo1.yaml:2
ok: [master.ipadomain.test]

TASK [Test multiple sudo rules] ************************************************************************
task path: /root/sudo1.yaml:7
fatal: [master.ipadomain.test]: FAILED! => {"changed": false, "msg": "missing required arguments: name"}

PLAY RECAP *********************************************************************************************
master.ipadomain.test      : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   

[varunmylaraiah]

The PR looks good to me, and downstream tests have passed with this PR

[t-woerner]

The tests are lacking the cleanup before the test items are created. This could lead to issues with existing, but conflicting items like for example external users.

[rjeffman]

@t-woerner test were fixed and TEMP commit removed.

[t-woerner]

LGTM