Improve callbacks for active controllers #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanscherzinger
force-pushed
the
improve-input-callbacks
branch
2 times, most recently
from
e89f504 to
8dd2ac0
Compare
stefanscherzinger
force-pushed
the
improve-input-callbacks
branch
4 times, most recently
from
9bdd9fa to
30e818c
Compare
This is cleaner and easier to understand for user applications: - Controllers process input only when active - This avoids sudden jumps upon activation due to some values from earlier callbacks. - Controllers don't spam `NaN` warnings when inactive and working with fake hardware.
stefanscherzinger
force-pushed
the
improve-input-callbacks
branch
from
30e818c to
de16202
Compare
stefanscherzinger
force-pushed
the
improve-input-callbacks
branch
from
de16202 to
91e1d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
NaN[ ] Use child loggers for the(handled in Use child loggers to silence NaN-specific controller warnings #183)NaNwarnings. This allows users to switch them off when working with fake hardware.Fixes #130