Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions to $defs #155

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Definitions to $defs #155

merged 2 commits into from
Sep 12, 2024

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Jul 25, 2024

This aligns the use of the "definitions" parameter to the "$defs" keyword as required from https://json-schema.org/draft/2020-12/schema as pointed out by @jrambla in #153

Editing of the YAML files with conversion... Additional changes include a change in the beaconYamler.py utility (use of system Python instead of fixed path) and a few updates of json files due to previous manual editing and now re-arranged parameter order after autoconversion from yaml.

costero-e and others added 2 commits July 18, 2024 18:55
Editing readme's changelog in order to update version
This aligns the use of the "definitions" parameter to the "$defs" keyword as required from https://json-schema.org/draft/2020-12/schema

Editing of the YAML files with conversion... Additional changes include a change in the beaconYamler.py utility (use of system Python instead of fixed path) and a few updates of json files due to previous manual editing and now re-arranged parameter order after autoconversion from yaml.
@mbaudis mbaudis requested review from costero-e and jrambla July 25, 2024 00:28
Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I reviewed this in my computer and I don't see any definitions missing to be changed. For me, this is good.

@jrambla jrambla merged commit ba16137 into schema-urgent-fixes Sep 12, 2024
1 check passed
@costero-e costero-e deleted the definitions-to-$defs branch December 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants