[#801] Export Metadata Subfield Formats #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: The comments have been moved :D Well, I was more tired than I thought today and all of these comments are on a PR and not the ticket I thought I was entering them into. Yikes. I'm going to consolidate and move these comments over now. |
|
I'm going to rebase this now that we have merged some more work. Edit: much cleaner diff with that rebase. I think there is a hangover function that is no longer needed I will remove quickly too. |
Meowcenary
force-pushed
the
801-export_metadata_subfield_formats
branch
from
1d4b2d6 to
570d863
Compare
Meowcenary
force-pushed
the
801-export_metadata_subfield_formats
branch
from
570d863 to
84f451c
Compare
sharpattack
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after 791 and 792 since it rebases off of those. Very small and simple PR.