Introduce sastfinding as a new finding type #1086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TuanAnh17N Thank you for your contribution. |
gardener-robot
added
the
size/xs
ccwienk
approved these changes
Nov 27, 2024
|
lgtm. however, we should mv this code to delivery-svc! |
8R0WNI3
requested changes
Nov 28, 2024
TuanAnh17N
force-pushed
the
sast-finding
branch
from
a305f82
to
ba0a289
Compare
8R0WNI3
reviewed
Nov 28, 2024
TuanAnh17N
force-pushed
the
sast-finding
branch
from
ba0a289
to
b7445a3
Compare
gardener-robot
added
the
size/s
gardener-robot
removed
the
size/xs
8R0WNI3
reviewed
Nov 28, 2024
TuanAnh17N
force-pushed
the
sast-finding
branch
from
b7445a3
to
9cc65fa
Compare
ccwienk
reviewed
Nov 29, 2024
| @@ -13,6 +13,17 @@ | |||
| import unixutil.model | |||
|
|
|||
|
|
|||
| class ComponentContext(enum.StrEnum): | |||
| INTERNAL = 'internal' | |||
There was a problem hiding this comment.
rather call it relation + reuse ocm's definition
ccwienk
reviewed
Nov 29, 2024
|
|
||
|
|
||
| class SastStatus(enum.StrEnum): | ||
| LOCAL_LINTING = 'local-linting' |
There was a problem hiding this comment.
can we inline those definitions into using code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: