Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sastfinding as a new finding type #1086

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Introduce sastfinding as a new finding type #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions dso/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,20 @@ def _as_key(
return separator.join(absent_indicator if arg is None else arg for arg in args)


class SastStatus(enum.StrEnum):
NO_LINTER = 'no-linter'


class SastSubType(enum.StrEnum):
LOCAL_LINTING = 'local-linting'
CENTRAL_LINTING = 'central-linting'


@dataclasses.dataclass
class MatchCondition:
component_name: str


@dataclasses.dataclass
class ScanArtifact:
name: str
Expand All @@ -33,6 +47,7 @@ class ScanArtifact:
class Datasource:
ARTEFACT_ENUMERATOR = 'artefact-enumerator'
BDBA = 'bdba'
SAST_LINT_CHECK = 'sast-lint-check'
CHECKMARX = 'checkmarx'
CLAMAV = 'clamav'
CC_UTILS = 'cc-utils'
Expand All @@ -53,6 +68,11 @@ def datasource_to_datatypes(datasource: str) -> tuple[str]:
Datatype.STRUCTURE_INFO,
Datatype.RESCORING,
),
Datasource.SAST_LINT_CHECK: (
Datatype.ARTEFACT_SCAN_INFO,
Datatype.SAST_FINDING,
Datatype.RESCORING,
),
Datasource.CHECKMARX: (
Datatype.CODECHECKS_AGGREGATED,
),
Expand Down Expand Up @@ -214,6 +234,7 @@ class Datatype:
LICENSE = 'finding/license'
VULNERABILITY = 'finding/vulnerability'
MALWARE_FINDING = 'finding/malware'
SAST_FINDING = 'finding/sast'
DIKI_FINDING = 'finding/diki'
CODECHECKS_AGGREGATED = 'codechecks/aggregated'
OS_IDS = 'os_ids'
Expand All @@ -234,6 +255,7 @@ def datatype_to_datasource(datatype: str) -> str:
Datatype.DIKI_FINDING: Datasource.DIKI,
Datatype.CRYPTO_ASSET: Datasource.CRYPTO,
Datatype.FIPS_FINDING: Datasource.CRYPTO,
Datatype.SAST_FINDING: Datasource.SAST_LINT_CHECK,
}[datatype]


Expand Down Expand Up @@ -380,6 +402,16 @@ def key(self) -> str:
return self.finding.key


@dataclasses.dataclass(frozen=True)
class SastFinding(Finding):
sast_status: SastStatus
sub_type: SastSubType

@property
def key(self) -> str:
return _as_key(self.sast_status, self.sub_type)


@dataclasses.dataclass(frozen=True)
class DikiCheck:
message: str
Expand Down Expand Up @@ -533,6 +565,7 @@ class CustomRescoring:
| RescoringLicenseFinding
| MalwareFindingDetails
| CryptoAsset
| SastFinding
)
referenced_type: str
severity: str
Expand Down Expand Up @@ -626,6 +659,7 @@ class ArtefactMetadata:
| LicenseFinding
| VulnerabilityFinding
| ClamAVMalwareFinding
| SastFinding
| DikiFinding
| CodecheckSummary
| OsID
Expand All @@ -652,6 +686,9 @@ def from_dict(raw: dict):
ComplianceSnapshotStatuses,
MetaRescoringRules,
AssetTypes,
SastSubType,
SastStatus,
MatchCondition
],
strict=True,
),
Expand Down
Loading