Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce sastfinding as a new finding type #1086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −0
Open

Introduce sastfinding as a new finding type #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions dso/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@
import unixutil.model


class ComponentContext(enum.StrEnum):
INTERNAL = 'internal'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather call it relation + reuse ocm's definition

PUBLIC = 'public'


class SastStatus(enum.StrEnum):
LOCAL_LINTING = 'local-linting'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we inline those definitions into using code?

NO_LINTING = 'no-linting'
CENTRAL_LINTING = 'central-linting'


@dataclasses.dataclass
class ScanArtifact:
name: str
Expand All @@ -24,6 +35,7 @@ class ScanArtifact:
class Datasource:
ARTEFACT_ENUMERATOR = 'artefact-enumerator'
BDBA = 'bdba'
CM06 = 'cm06'
TuanAnh17N marked this conversation as resolved.
Show resolved Hide resolved
CHECKMARX = 'checkmarx'
CLAMAV = 'clamav'
CC_UTILS = 'cc-utils'
Expand All @@ -43,6 +55,11 @@ def datasource_to_datatypes(datasource: str) -> tuple[str]:
Datatype.STRUCTURE_INFO,
Datatype.RESCORING,
),
Datasource.CM06: (
Datatype.ARTEFACT_SCAN_INFO,
Datatype.SAST_FINDING,
TuanAnh17N marked this conversation as resolved.
Show resolved Hide resolved
Datatype.RESCORING,
),
Datasource.CHECKMARX: (
Datatype.CODECHECKS_AGGREGATED,
),
Expand Down Expand Up @@ -193,6 +210,7 @@ class Datatype:
LICENSE = 'finding/license'
VULNERABILITY = 'finding/vulnerability'
MALWARE_FINDING = 'finding/malware'
SAST_FINDING = 'finding/sast'
TuanAnh17N marked this conversation as resolved.
Show resolved Hide resolved
DIKI_FINDING = 'finding/diki'
CODECHECKS_AGGREGATED = 'codechecks/aggregated'
OS_IDS = 'os_ids'
Expand All @@ -209,6 +227,7 @@ def datatype_to_datasource(datatype: str) -> str:
Datatype.CODECHECKS_AGGREGATED: Datasource.CHECKMARX,
Datatype.MALWARE_FINDING: Datasource.CLAMAV,
Datatype.DIKI_FINDING: Datasource.DIKI,
Datatype.SAST_FINDING: Datasource.CM06,
}[datatype]


Expand Down Expand Up @@ -355,6 +374,16 @@ def key(self) -> str:
return self.finding.key


@dataclasses.dataclass(frozen=True)
class SastFinding(Finding):
TuanAnh17N marked this conversation as resolved.
Show resolved Hide resolved
sast_statuses: list[SastStatus] | SastStatus
component_context: ComponentContext

@property
def key(self) -> str:
return f'{self.component_context}|{self.sast_statuses}'


@dataclasses.dataclass(frozen=True)
class DikiCheck:
message: str
Expand Down Expand Up @@ -410,6 +439,7 @@ class CustomRescoring:
RescoringVulnerabilityFinding
| RescoringLicenseFinding
| MalwareFindingDetails
| SastFinding
)
referenced_type: str
severity: str
Expand Down Expand Up @@ -498,6 +528,7 @@ class ArtefactMetadata:
| LicenseFinding
| VulnerabilityFinding
| ClamAVMalwareFinding
| SastFinding
| DikiFinding
| CodecheckSummary
| OsID
Expand Down