Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom Fuel cache location for tests #213

Merged
merged 4 commits into from
Jun 24, 2020

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jun 18, 2020

This ensures that tests are repeatable and are not affected by preexisting
models in the regular user's cache.

Related issue gazebosim/gz-fuel-tools#80

This ensures that tests are repeatable and are not affected by preexisting
models in the regular user's cache.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from chapulina as a code owner June 18, 2020 19:15
@azeey azeey self-assigned this Jun 18, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works, I just have some comments on implementation details.

src/SdfGenerator_TEST.cc Outdated Show resolved Hide resolved
test/integration/breadcrumbs.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The new helper class is going to be very useful!

@chapulina chapulina merged commit 26488b2 into gazebosim:ign-gazebo2 Jun 24, 2020
@azeey azeey deleted the fuel_cache_for_tests branch June 25, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants