-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pindel artifact annotation and filter #71
Conversation
@@ -21,6 +21,16 @@ properties: | |||
Path to resources.yaml file | |||
format: uri-reference | |||
|
|||
pacbio_alignment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this and ont_alignment
related to the artifact filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no. With the artifact filter i needed to update the cnv_sv module, and in the new version there are some rules for long-read added and by that a new format possible format for the units file. The pacbio_alignment
and ont_alignment
are used to separate a short-read from a long-read units.tsv.
Jonas and Padraic are working on a solution where Hydra can figure out what type of sequencing are used by itself. But for now its the _alignment
variables that determines which columns should be used, so I set those to False by default for Poppy since it is designed for short-read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through it, and from what I can tell it looks alright. I won't be able to test it properly since I'm on holiday, but I trust that it works on your end, and the tests are passing. I have a lot of testing to do when I get back in August.
Haha no worries, don't forget to have actual vacation as well! 🌴 😎 |
No description provided.