Adding run_started_at to query comment #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisset-a
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
bisset-a
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
NiallRees
reviewed
May 7, 2024
macros/query_comment.sql
Outdated
| @@ -23,6 +23,7 @@ | |||
| node_resource_type=node.resource_type, | |||
| node_meta=node.config.meta, | |||
| node_tags=node.tags, | |||
| run_started_at=run_started_at.strftime("%Y-%m-%d %H:%M:%S"), | |||
There was a problem hiding this comment.
Can we go with https://docs.python.org/3/library/datetime.html#datetime.datetime.isoformat and include a timezone?
There was a problem hiding this comment.
Hey @NiallRees!! I've just updated and tested:
|
Thanks for contributing this @bisset-a 🙌 |
bisset-a
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
No problems @NiallRees , thanks for providing the macros 😄 they'll be very useful for us! |
robscriva
reviewed
May 14, 2024
| @@ -23,6 +23,7 @@ | |||
| node_resource_type=node.resource_type, | |||
| node_meta=node.config.meta, | |||
| node_tags=node.tags, | |||
| run_started_at=run_started_at.astimezone(modules.pytz.utc).isoformat(), | |||
| full_refresh=flags.FULL_REFRESH, | |||
There was a problem hiding this comment.
Should this go up higher with the invocation_id and other non-node specific details?
NiallRees
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
run_started_atto the query comment