Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding run_started_at to query comment #27

Merged
merged 3 commits into from
May 14, 2024
Merged

Adding run_started_at to query comment #27

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fbeb28
Adding run_started_at to query comment
bisset-a May 6, 2024
0c562e6
Adding changelog entry
bisset-a May 6, 2024
12d4e34
Update query_comment.sql
bisset-a May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20240506-131218.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Add run_started_at to query comment
time: 2024-05-06T13:12:18.799857+10:00
custom:
Author: bisset-a
PR: "27"
1 change: 1 addition & 0 deletions macros/query_comment.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
node_resource_type=node.resource_type,
node_meta=node.config.meta,
node_tags=node.tags,
run_started_at=run_started_at.strftime("%Y-%m-%d %H:%M:%S"),
Copy link
Member

@NiallRees NiallRees May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go with https://docs.python.org/3/library/datetime.html#datetime.datetime.isoformat and include a timezone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NiallRees!! I've just updated and tested:
image

full_refresh=flags.FULL_REFRESH,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go up higher with the invocation_id and other non-node specific details?

which=flags.WHICH,
) -%}
Expand Down
Loading