Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 and Python 3.12 #179

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

astrojuanlu
Copy link

Description

Add support for Python 3.11 and, in turn, 3.12 too.

I completely lifted the upper version cap for the Python version. See:

The side effect of that is that users may attempt to install on Python 3.13, but since there are no precompiled wheels of pyarrow==17.0.0 it will fail unless the user system has the necessary dependencies. This doesn't mean that it isn't technically possible to use kedro-vertexai on Python 3.13, it's just that I haven't tried. The user would get a warning coming from Kedro anyway, see kedro-org/kedro#2742 🔶

I also added 3.11 and 3.12 to the test matrix.

Resolves #139, resolves #146

I think the errors observed by @Lasica in #146 were due to Poetry bugs and not necessarily dependency incompatibilities. So I ran pdm import to migrate the project metadata to PEP 621 (the only reason I chose PDM was because such import command existed, with a trivial change this can be migrated to Hatch or any other PEP 621-compliant workflow tool). This doesn't have user impact.

PR Checklist

@astrojuanlu
Copy link
Author

To note, Poetry 2.0 is approaching python-poetry/poetry#9136 so maybe this PR can be updated afterwards to avoid migrating to PDM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant