nginx: add tests for config #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Sep 19, 2024
alxndrsn
commented
Sep 19, 2024
| # KEEP THIS FILE AS CLOSE AS POSSIBLE TO ../nginx.dockerfile | ||
| # | ||
| # It is ESPECIALLY IMPORTANT to keep IDENTICAL BASE IMAGES. | ||
| # |
There was a problem hiding this comment.
One alternative to this copy/paste could be INCLUDE+ (https://github.com/edrevo/dockerfile-plus)
There was a problem hiding this comment.
Let's address this as part of #677 Then I think we can use our actual published nginx image as the base image. That would include the frontend code which seems fine.
Now I'm confused. Why not use the actual image now? Is it to try to have a more isolated test?
alxndrsn
force-pushed
the
nginx-testing
branch
3 times, most recently
from
b8572ab to
924a107
Compare
alxndrsn
force-pushed
the
nginx-testing
branch
from
924a107 to
0da0ae8
Compare
lognaturel
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.