Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove metrics API from the JS SDK #14745

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Dec 16, 2024

deprecation PR: #14157

resolves #14264

  1. Removes metrics export and all it's usages
  2. Removes all usages of _metrics_summary from the SDK
  3. Removes metricsShim usage in the browser SDK CDN bundles
  4. Removes all metrics related types from the SDK

@AbhiPrasad AbhiPrasad self-assigned this Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.12 KB -0.41% -96 B 🔽
@sentry/browser - with treeshaking flags 21.81 KB -0.33% -73 B 🔽
@sentry/browser (incl. Tracing) 35.62 KB -0.33% -119 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.87 KB -0.17% -126 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.28 KB -0.15% -92 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 77.27 KB -0.16% -119 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.67 KB -0.11% -101 B 🔽
@sentry/browser (incl. Feedback) 39.87 KB -0.23% -94 B 🔽
@sentry/browser (incl. sendFeedback) 27.74 KB -0.32% -89 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.5 KB -0.29% -96 B 🔽
@sentry/react 25.84 KB -0.32% -83 B 🔽
@sentry/react (incl. Tracing) 38.5 KB -0.24% -93 B 🔽
@sentry/vue 27.36 KB -0.37% -102 B 🔽
@sentry/vue (incl. Tracing) 37.5 KB -0.28% -107 B 🔽
@sentry/svelte 23.29 KB -0.41% -96 B 🔽
CDN Bundle 24.23 KB -0.55% -137 B 🔽
CDN Bundle (incl. Tracing) 35.78 KB -4.4% -1.64 KB 🔽
CDN Bundle (incl. Tracing, Replay) 70.87 KB -2.28% -1.65 KB 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 76.18 KB -2.19% -1.71 KB 🔽
CDN Bundle - uncompressed 71.14 KB -0.58% -424 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 106.65 KB -3.86% -4.27 KB 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.7 KB -1.9% -4.27 KB 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.91 KB -1.8% -4.28 KB 🔽
@sentry/nextjs (client) 38.75 KB -0.26% -100 B 🔽
@sentry/sveltekit (client) 36.17 KB -0.27% -100 B 🔽
@sentry/node 157.98 KB -0.06% -84 B 🔽
@sentry/node - without tracing 98.93 KB -0.07% -62 B 🔽
@sentry/aws-serverless 126.63 KB -0.07% -88 B 🔽

View base workflow run

@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team December 17, 2024 02:53
@AbhiPrasad AbhiPrasad marked this pull request as ready for review December 17, 2024 02:53
@AbhiPrasad AbhiPrasad added this to the 9.0.0 milestone Dec 17, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP :(

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 17, 2024 18:02
@AbhiPrasad AbhiPrasad merged commit d773cb7 into develop Dec 17, 2024
156 of 157 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-remove-metrics branch December 17, 2024 18:19
Lei-k added a commit to Lei-k/sentry-javascript that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9] Remove Metrics API
2 participants