Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove metrics API from the JS SDK #14745

Merged
merged 9 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

159 changes: 0 additions & 159 deletions dev-packages/browser-integration-tests/suites/metrics/timing/test.ts

This file was deleted.

12 changes: 0 additions & 12 deletions dev-packages/browser-integration-tests/utils/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,18 +270,6 @@ export function shouldSkipFeedbackTest(): boolean {
return false;
}

/**
* We can only test metrics tests in certain bundles/packages:
* - NPM (ESM, CJS)
* - CDN bundles that include tracing
*
* @returns `true` if we should skip the metrics test
*/
export function shouldSkipMetricsTest(): boolean {
const bundle = process.env.PW_BUNDLE as string | undefined;
return bundle != null && !bundle.includes('tracing') && !bundle.includes('esm') && !bundle.includes('cjs');
}

/**
* We only test feature flags integrations in certain bundles/packages:
* - NPM (ESM, CJS)
Expand Down

This file was deleted.

18 changes: 0 additions & 18 deletions dev-packages/node-integration-tests/suites/metrics/should-exit.js

This file was deleted.

Loading
Loading