Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samba to version v4.20.5 #1724

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Update samba to version v4.20.5 #1724

merged 3 commits into from
Nov 5, 2024

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Oct 31, 2024

🤖 This is an automated pull request to update samba to version v4.20.5-r0. This PR must be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Oct 31, 2024

🤖 This is an automated summary of installation tests for samba:

  • ✅ App successfully installed in umbrel-dev instance
  • ✅ App successfully listed in umbrel.yaml
  • ✅ App UI successfully returns a 200 status code
  • 📸 Screenshot of the app:
    App Screenshot

This PR must still be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Oct 31, 2024

@joaovictor-local just a friendly ping before I merge this. Would you be interested and able to update your UI container based on @sharknoon's suggestion here:
#1161 (comment)

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ samba/docker-compose.yml External port mapping "446:445":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz nmfretz changed the title Update samba to version v4.20.5-r0 Update samba to version v4.20.5 Oct 31, 2024
@nmfretz
Copy link
Contributor Author

nmfretz commented Nov 5, 2024

Reviewed and tested. No response on updating the UI instructions, so merging as-is.

@nmfretz nmfretz merged commit b5b1a92 into master Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant