Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samba to version v4.20.5 #1724

Merged
merged 3 commits into from
Nov 5, 2024
+6 −3
Merged

Update samba to version v4.20.5 #1724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
194a1db
Update samba to v4.20.5-r0
nmfretz Oct 31, 2024
a389351
Remove '-r0' from version in manifest
nmfretz Oct 31, 2024
d0a8219
Add generic release notes
nmfretz Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samba/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@
- ${APP_DATA_DIR}/data/samba/smb.conf:/public/smb.conf:ro

server:
image: dockurr/samba:4.20.2@sha256:f5b3eb5d1d6866b23c7b12259a0f7ec20b991e450785cb710f09e54bcef79e47
image: dockurr/samba:4.20.5@sha256:f462ae8310ab74816cba51ed4048eb0762a023800338e053dac1eb8099f4f8b4
restart: on-failure
environment:
USER: umbrel
PASS: ${APP_PASSWORD}
UID: 1000
GID: 1000
ports:

Check notice on line 24 in samba/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

External port mapping "446:445" 

Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
- '446:445'
volumes:
- ${APP_DATA_DIR}/data/samba/smb.conf:/etc/samba/smb.conf
Expand Down
7 changes: 5 additions & 2 deletions samba/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ id: samba
name: Samba
tagline: Make your storage accessible using Samba
category: networking
version: "4.20.2"
version: "4.20.5"
port: 9445
description: >-
📂 Simplify your file sharing with Samba!
Expand Down Expand Up @@ -37,7 +37,10 @@ gallery:
- 2.jpg
- 3.jpg
releaseNotes: >-
This update fixes an issue with library version strings in Samba 4.20.3. For more details, visit: https://bugzilla.samba.org/show_bug.cgi?id=15673
This release updates the underlying samba service to v4.20.5.


Full release notes can be found at https://github.com/dockur/samba/releases/tag/v4.20.5-r0
dependencies: []
path: ""
defaultUsername: "umbrel"
Expand Down