Cluster admin flag adjustment #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvondruska
force-pushed
the
cluster-admin-flag-adjustment
branch
from
4d5e564
to
2894dff
Compare
marians
reviewed
Aug 15, 2023
Co-authored-by: Marian Steinbach <[email protected]>
mogottsch
approved these changes
Aug 16, 2023
anvddriesch
approved these changes
Aug 16, 2023
marians
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adjusted description of the
--cluster-adminflag in thelogincommand to better fit the purpose of the flag - to be used by Ginatswarm staff to log in to clustersWhat is the effect of this change to users?
The description of the
--cluster-adinflag has been change. There are no impacts on any kgs features.What does it look like?
The new description is
Log in as Giantswarm staff member.Any background context you can provide?
Towards giantswarm/roadmap#1530
What is needed from the reviewers?
Check if the new description makes sense.
Do the docs need to be updated?
If the flag is mentioned in the docs, then its description probably needs to be updated.
Should this change be mentioned in the release notes?
Is this a breaking change?
No
(Breaking changes are, for example, removal of commnds/flags or substantial changes in the meaning of a flag. If yes, please add the
breaking-changelabel to the PR.)