Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster admin flag adjustment #1101

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Cluster admin flag adjustment #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4065707
Adjusted description of cluster-admin login flag
vvondruska Aug 9, 2023
2894dff
Updated changelog
vvondruska Aug 9, 2023
f0cfb4f
Merge branch 'main' into cluster-admin-flag-adjustment
vvondruska Aug 15, 2023
cbfafb0
Update cmd/login/flag.go
vvondruska Aug 16, 2023
d65d6c4
Merge branch 'main' into cluster-admin-flag-adjustment
vvondruska Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s

- Graceful failure of the `login` command in case workload cluster API is not known
- Improved error message after login timeout
- Adjusted description of the `--cluster-admin` flag in the `login` command

## [2.39.0] - 2023-06-22

Expand Down
2 changes: 1 addition & 1 deletion cmd/login/flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ type flag struct {

func (f *flag) Init(cmd *cobra.Command) {
cmd.Flags().IntVar(&f.CallbackServerPort, callbackServerPort, 0, "TCP port to use by the OIDC callback server. If not specified, a free port will be selected randomly.")
cmd.Flags().BoolVar(&f.ClusterAdmin, flagClusterAdmin, false, "Login with cluster-admin access.")
cmd.Flags().BoolVar(&f.ClusterAdmin, flagClusterAdmin, false, "Log in as Giant Swarm staff member.")
cmd.Flags().BoolVar(&f.InternalAPI, flagInternalAPI, false, "Use Internal API in the kube config. Please check the documentation for more details.")
cmd.Flags().StringVar(&f.SelfContained, flagSelfContained, "", "Create a self-contained kubectl config with embedded credentials and write it to this path.")
cmd.Flags().BoolVar(&f.KeepContext, flagKeepContext, false, "Keep the current kubectl context. If not set/false, will set the current-context to the one representing the cluster to log in to.")
Expand Down