Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to improve mainteinability/understability of the test cases #52

Open
augustocristian opened this issue Dec 3, 2023 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@augustocristian
Copy link
Contributor

Upon reviewing the code for the "DeleteCourse" test, I've identified several changes that could enhance the comprehensibility of the test cases, particularly when they fail:

There are multiple instances of code duplications in certain classes, with most test cases (e.g., CourseTeacher tests) having the potential for simplification. By removing these duplications, we can centralize the root cause of flakiness into a single block of code.

Debugging videos can be challenging at times, primarily because users are not consistently initialized, and the test case name is not provided. Modifying the initialization process for each test case, such as in the eShopContainers, might be beneficial. While incorporating Selenium could be useful, I am unable to suggest an approach without simplifying the code first.

Several parts of the code can be eliminated, including some methods that return values that are not useful at all. Removing these unnecessary components will streamline the codebase

I dont want to lost the focus on the actual priority (eShopContainers) but I want to open this issue as reminder

@augustocristian augustocristian added the enhancement New feature or request label Dec 3, 2023
@augustocristian augustocristian self-assigned this Dec 3, 2023
@javiertuya javiertuya added the wontfix This will not be worked on label Dec 4, 2023
@javiertuya
Copy link
Contributor

Unassign and label because this is not priority now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants