Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new sonarcloud smells #319

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Fix new sonarcloud smells #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca77a6
Update Base.java
giis-qabot Dec 8, 2024
4243ec1
Update TestSqlserverSchemaMetadata.java
giis-qabot Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tdrules-client-oa/src/test/java/test4giis/tdrules/client/oa/Base.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ protected void assertModelMermaid(String fileName, String mermaidModel) throws I
protected void assertModelFile(String fileName, String actualFile) throws IOException {
// saves actual in target, reads expected file from resources and performs the
// assert
fileWrite(TEST_PATH_OUTPUT, fileName, actualFile.toString());
fileWrite(TEST_PATH_OUTPUT, fileName, actualFile);
actualFile = actualFile.replace("\r", "");
String expected = fileRead(TEST_PATH_BENCHMARK, fileName).replace("\r", "");
new VisualAssert().setFramework(Framework.JUNIT4).setBrightColors(true)
Expand Down
6 changes: 4 additions & 2 deletions tdrules-store-rdb/src/test/java/test4giis/tdrules/store/rdb/TestSqlserverSchemaMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ protected void createViewXXL() throws SQLException {
String createViewSql = "select tinteger,tint4,tcharacter from stypes1";
String addView = " \nunion all " + createViewSql;
int numRepeats = 10000 / addView.length();
StringBuilder sb = new StringBuilder();
sb.append(createViewSql);
for (int i = 0; i < numRepeats; i++)
createViewSql += addView;
execute(dbt, createViewMain + createViewSql);
sb.append(addView);
execute(dbt, createViewMain + sb.toString());
}

protected void createTablesAndViews() throws SQLException {
Expand Down
Loading