Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open AI Assistants #3119

Merged
merged 20 commits into from
Nov 11, 2024
Merged

Open AI Assistants #3119

merged 20 commits into from
Nov 11, 2024

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Oct 16, 2024

target issue is #3038 #3004

Copy link

github-actions bot commented Oct 16, 2024

@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 03:09 Inactive
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (5391389) to head (edc69ea).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...s/Assistants/AssistantOptions/AssistantOptions.tsx 87.50% 3 Missing and 3 partials ⚠️
src/containers/Assistants/ListItems/List.tsx 89.65% 1 Missing and 2 partials ⚠️
...ers/Assistants/CreateAssistant/CreateAssistant.tsx 96.49% 1 Missing and 1 partial ⚠️
src/components/UI/HelpIcon/HelpIcon.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
+ Coverage   81.49%   81.69%   +0.19%     
==========================================
  Files         320      328       +8     
  Lines       10281    10470     +189     
  Branches     2187     2219      +32     
==========================================
+ Hits         8379     8553     +174     
- Misses       1296     1304       +8     
- Partials      606      613       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 16, 2024

Glific    Run #5363

Run Properties:  status check passed Passed #5363  •  git commit 1dde25d91c ℹ️: Merge edc69ea8dbdc281406237c7db42f1578efc05726 into 53913890e8147a0aac10f653ecc3...
Project Glific
Branch Review feature/assistants
Run status status check passed Passed #5363
Run duration 24m 44s
Commit git commit 1dde25d91c ℹ️: Merge edc69ea8dbdc281406237c7db42f1578efc05726 into 53913890e8147a0aac10f653ecc3...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@akanshaaa19 akanshaaa19 changed the title Open Ai Assistants Open AI Assistants Oct 16, 2024
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 05:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 05:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 16, 2024 15:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 03:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 04:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 28, 2024 04:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 12:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 16:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 16:38 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund November 5, 2024 03:38
@akanshaaa19 akanshaaa19 self-assigned this Nov 5, 2024
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 04:40 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

Overall looks good. Added minor comments.

Can you please remove right border

Screenshot 2024-11-05 at 23 37 35

animation: jiggle 0.5s ease-in-out;
}

@keyframes jiggle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really :)

src/containers/Assistants/Assistants.tsx Outdated Show resolved Hide resolved
{
component: AutoComplete,
name: 'model',
options: modelOptions || [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like changing value of this autocomplete leads to lot of warnings, please fix.

@github-actions github-actions bot temporarily deployed to pull request November 6, 2024 07:58 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund November 7, 2024 15:52
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged once backend PR is merged.

@kurund
Copy link
Contributor

kurund commented Nov 7, 2024

Looks good and can be merged once backend PR is merged.

Sorry, I can still see the border on Safari.

Screenshot 2024-11-07 at 22 25 59

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the border line

@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 04:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 04:41 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund November 8, 2024 04:49
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 08:06 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@akanshaaa19 akanshaaa19 requested a review from kurund November 8, 2024 09:25
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 09:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 8, 2024 14:07 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now.

@kurund kurund merged commit 89943b2 into master Nov 11, 2024
12 of 13 checks passed
@kurund kurund deleted the feature/assistants branch November 11, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master issue for OpenAI Filesearch GPT Filesearch: Adding UI support
2 participants