-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open AI Assistants #3119
Open AI Assistants #3119
Conversation
🚀 Deployed on https://deploy-preview-3119--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3119 +/- ##
==========================================
+ Coverage 81.49% 81.69% +0.19%
==========================================
Files 320 328 +8
Lines 10281 10470 +189
Branches 2187 2219 +32
==========================================
+ Hits 8379 8553 +174
- Misses 1296 1304 +8
- Partials 606 613 +7 ☔ View full report in Codecov by Sentry. |
Glific Run #5363
Run Properties:
|
Project |
Glific
|
Branch Review |
feature/assistants
|
Run status |
Passed #5363
|
Run duration | 24m 44s |
Commit |
1dde25d91c ℹ️: Merge edc69ea8dbdc281406237c7db42f1578efc05726 into 53913890e8147a0aac10f653ecc3...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
…d into feature/assistants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
animation: jiggle 0.5s ease-in-out; | ||
} | ||
|
||
@keyframes jiggle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really :)
{ | ||
component: AutoComplete, | ||
name: 'model', | ||
options: modelOptions || [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like changing value of this autocomplete leads to lot of warnings, please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and can be merged once backend PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the border line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good now.
target issue is #3038 #3004