Remove redundant asset preload #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preloading these is already handled by glitch-soc theming system, meaning glitch packs get preloaded and if the user is signed in, vanilla packs. The theming system preloads these unconditionally though. Signed-off-by: Plastikmensch <[email protected]>
This matches upstreams preloads Signed-off-by: Plastikmensch <[email protected]>
rezhajulio
pushed a commit
to PegelinuxTop/mastodon
that referenced
this pull request
Dec 5, 2023
* Remove redundant asset preload preloading these is already handled by glitch-soc theming system, meaning glitch packs get preloaded and if the user is signed in, vanilla packs. The theming system preloads these unconditionally though. Signed-off-by: Plastikmensch <[email protected]> * Remove preload of getting started This matches upstreams preloads Signed-off-by: Plastikmensch <[email protected]> --------- Signed-off-by: Plastikmensch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preloading is handled by glitch-soc's theming system, so all this currently did was to preload vanilla packs into glitch and preload twice in vanilla if the user was signed in.
The theming system does not conditionally preload though, but I wanted to leave that up for discussion before making changes. I'm not sure preloading is at all really necessary, but it is done upstream.
(Sidenote: the theming system seems to need some work)
Preload of getting-started has been removed as it was removed in 62782ba