-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libraries and fix openssl 1.1 qt4 build. #610
base: master
Are you sure you want to change the base?
Conversation
392f066
to
3bb6aee
Compare
3bb6aee
to
c643919
Compare
@jameshilliard - Thanks for looking into this. Which version of macOS are you running? I recently upgraded my Mac and am now on 10.15.2. I'm getting some compile errors. I can fire up a 10.14 VM. I just wanted to get your info first. |
I was trying to get this to work on 10.14 but was having some build issues(that seem unrelated to openssl), the last release was built on 10.13 right? Can you try building on a 10.13 system? |
Okay. I fired up and updated my 10.13 VM. I see the following Qt issue.
|
Did you update homebrew/openssl to the latest version as well? |
@@ -18,26 +18,26 @@ | |||
from tempfile import mkstemp | |||
|
|||
# Set some constants up front | |||
minOSXVer = '10.8' | |||
pythonVer = '2.7.15' # NB: ArmoryMac.pro must also be kept up to date!!! | |||
minOSXVer = '10.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe try with this reverted?
Ahhh, yeah, I forgot to update all that. Getting closer. I can build but now I have a
While we're at it, one good thing to do would be to mod the compile steps before this is pulled. For example, I had to run |
Does it work if you take just the 2 openssl qt4 patches I added without any of the other changes? |
Should hopefully fix this error due to homebrew removing openssl 1.0:
@droark Could you try building with these changes after updating to the latest homebrew openssl?