forked from etotheipi/BitcoinArmory
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libraries and fix openssl 1.1 qt4 build. #610
Open
jameshilliard
wants to merge
1
commit into
goatpig:master
Choose a base branch
from
jameshilliard:library-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
Description: Do not use SSLv3 methods in Qt4 | ||
This patch makes the use of SSLv3 methods optional at compile time. | ||
On Debian this means they will not be used and will return a null ctx | ||
if the SSLv3 method is deliberately selected. | ||
Author: Jon DeVree <[email protected]> | ||
Origin: other, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806505 | ||
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806505 | ||
Forwarded: not-needed | ||
Reviewed-by: Lisandro Damián Nicanor Pérez Meyer <[email protected]> | ||
Last-Update: 2015-11-30 | ||
--- | ||
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ | ||
diff -Nru qt4-x11-4.8.7+dfsg.orig/src/network/ssl/qsslsocket_openssl.cpp qt4-x11-4.8.7+dfsg/src/network/ssl/qsslsocket_openssl.cpp | ||
--- qt4-x11-4.8.7+dfsg.orig/src/network/ssl/qsslsocket_openssl.cpp 2015-05-07 10:14:44.000000000 -0400 | ||
+++ qt4-x11-4.8.7+dfsg/src/network/ssl/qsslsocket_openssl.cpp 2015-11-27 20:49:36.768826857 -0500 | ||
@@ -267,7 +267,11 @@ | ||
#endif | ||
break; | ||
case QSsl::SslV3: | ||
+#ifndef OPENSSL_NO_SSL3_METHOD | ||
ctx = q_SSL_CTX_new(client ? q_SSLv3_client_method() : q_SSLv3_server_method()); | ||
+#else | ||
+ ctx = 0; // SSL 3 not supported by the system, but chosen deliberately -> error | ||
+#endif | ||
break; | ||
case QSsl::SecureProtocols: // SslV2 will be disabled below | ||
case QSsl::TlsV1SslV3: // SslV2 will be disabled below | ||
diff -Nru qt4-x11-4.8.7+dfsg.orig/src/network/ssl/qsslsocket_openssl_symbols.cpp qt4-x11-4.8.7+dfsg/src/network/ssl/qsslsocket_openssl_symbols.cpp | ||
--- qt4-x11-4.8.7+dfsg.orig/src/network/ssl/qsslsocket_openssl_symbols.cpp 2015-05-07 10:14:44.000000000 -0400 | ||
+++ qt4-x11-4.8.7+dfsg/src/network/ssl/qsslsocket_openssl_symbols.cpp 2015-11-27 20:49:48.061023402 -0500 | ||
@@ -228,13 +228,17 @@ | ||
#ifndef OPENSSL_NO_SSL2 | ||
DEFINEFUNC(const SSL_METHOD *, SSLv2_client_method, DUMMYARG, DUMMYARG, return 0, return) | ||
#endif | ||
+#ifndef OPENSSL_NO_SSL3_METHOD | ||
DEFINEFUNC(const SSL_METHOD *, SSLv3_client_method, DUMMYARG, DUMMYARG, return 0, return) | ||
+#endif | ||
DEFINEFUNC(const SSL_METHOD *, SSLv23_client_method, DUMMYARG, DUMMYARG, return 0, return) | ||
DEFINEFUNC(const SSL_METHOD *, TLSv1_client_method, DUMMYARG, DUMMYARG, return 0, return) | ||
#ifndef OPENSSL_NO_SSL2 | ||
DEFINEFUNC(const SSL_METHOD *, SSLv2_server_method, DUMMYARG, DUMMYARG, return 0, return) | ||
#endif | ||
+#ifndef OPENSSL_NO_SSL3_METHOD | ||
DEFINEFUNC(const SSL_METHOD *, SSLv3_server_method, DUMMYARG, DUMMYARG, return 0, return) | ||
+#endif | ||
DEFINEFUNC(const SSL_METHOD *, SSLv23_server_method, DUMMYARG, DUMMYARG, return 0, return) | ||
DEFINEFUNC(const SSL_METHOD *, TLSv1_server_method, DUMMYARG, DUMMYARG, return 0, return) | ||
#else | ||
@@ -822,13 +826,17 @@ | ||
#ifndef OPENSSL_NO_SSL2 | ||
RESOLVEFUNC(SSLv2_client_method) | ||
#endif | ||
+#ifndef OPENSSL_NO_SSL3_METHOD | ||
RESOLVEFUNC(SSLv3_client_method) | ||
+#endif | ||
RESOLVEFUNC(SSLv23_client_method) | ||
RESOLVEFUNC(TLSv1_client_method) | ||
#ifndef OPENSSL_NO_SSL2 | ||
RESOLVEFUNC(SSLv2_server_method) | ||
#endif | ||
+#ifndef OPENSSL_NO_SSL3_METHOD | ||
RESOLVEFUNC(SSLv3_server_method) | ||
+#endif | ||
RESOLVEFUNC(SSLv23_server_method) | ||
RESOLVEFUNC(TLSv1_server_method) | ||
RESOLVEFUNC(X509_NAME_entry_count) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe try with this reverted?