Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize more common modules into dune libraries #1288

Merged
merged 20 commits into from
Dec 8, 2023
Merged

Organize more common modules into dune libraries #1288

merged 20 commits into from
Dec 8, 2023

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Dec 7, 2023 •
edited
Loading

This continues #1206.
By moving a couple of functions to better-suited modules, some odd module dependencies can be eliminated, allowing more things to be decomposed.

This PR introduces new dune libraries:

  1. goblint.config for the JSON configuration system.
  2. goblint.domain for general-purpose domain (Lattice) functors (e.g. SetDomain).
  3. goblint.library for library function specifications.
  4. goblint.incremental for incremental comparison and updating.
  5. goblint.tracing for tracing.

TODO

sim642 added 17 commits December 6, 2023 15:31
@sim642
Remove unused MyCheck.Arbitrary.varinfo
02721c6
@sim642
Move MyCheck to goblint.std as GobQCheck
152ed0d
@sim642
Remove Basetype dependency on Lattice
c7f94ff
@sim642
Remove Lattice dependency on GobConfig
983a226
@sim642
Fix unittest compilation
a4f9689
@sim642
Extract Lattice to goblint_domain dune library
19bcd3a
@sim642
Move general domains to goblint_domain library
5937314
@sim642
Remove Tracing dependency on CilType
1eb7af8
@sim642
Extract Tracing to goblint_tracing dune library
1ac6baf
@sim642
Extract configuration to goblint_config dune library
54d7fdf
@sim642
Update Gobview dependencies on Goblint libraries
b5f6272
@sim642
Remove CfgTools dependency on IntDomain via Offset
036a016
@sim642
Remove CompareCFG dependency on CfgTools
dbec9e8
@sim642
Move CfgTools to goblint_common
3dd3551
@sim642
Extract incremental to goblint_incremental dune library
deb727b
@sim642
Extract library specificaton to goblint_library dune library
9261b71
@sim642
Fix LibraryFunctions.invalidate_actions indentation
5662024
@sim642 sim642 added the cleanup Refactoring, clean-up label Dec 7, 2023
@sim642 sim642 added this to the v2.4.0 milestone Dec 7, 2023
@sim642 sim642 mentioned this pull request Dec 7, 2023
Merged
@michael-schwarz michael-schwarz self-requested a review December 7, 2023 10:23
michael-schwarz
michael-schwarz approved these changes Dec 7, 2023
View reviewed changes
src/cdomains/offset.ml Show resolved Hide resolved
src/framework/constraints.ml Show resolved Hide resolved
@sim642 sim642 merged commit 5456999 into master Dec 8, 2023
16 checks passed
@sim642 sim642 deleted the goblint-dune-libs-2 branch December 8, 2023 08:48
@sim642 sim642 mentioned this pull request Dec 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-schwarz michael-schwarz michael-schwarz approved these changes

Assignees
No one assigned
Labels
cleanup Refactoring, clean-up
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sim642 @michael-schwarz