Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multisample support for ShadingRatePattern. #493

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

jorgeag-google
Copy link
Collaborator

The fourth of a series of CL that integrates the commits from:
https://github.com/bjoeris/bigwheels/tree/experimental-foveation
into BW main's branch.
The series has 4 CL, this is the last one that integrates the following commit

  • Add multisample support for ShadingRatePattern.

Beside the foveation sample app, it also adds the following changes in BW infra:

  • ShadingRate’s class add sample count properties, that queries from device
  • Modifies gfx View classes to get the sample count from images
  • Image class get samples count from createinfo struct
  • ShadingRates unit test get modified to account for this changes

Copy link
Collaborator

@bjoeris bjoeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apazylbe apazylbe requested a review from Keenuts July 23, 2024 18:20
@apazylbe apazylbe merged commit d5ffe4b into google:main Jul 23, 2024
5 checks passed
@jorgeag-google jorgeag-google deleted the integration4 branch July 23, 2024 18:40
jorgeag-google added a commit that referenced this pull request Jul 29, 2024
Makes the foveation app able to use multisample foveation

This change was missing from the previous PR #493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants