Adding dualgate table rules #3
Conversation
|
@proppy Please check and let me know. Once this is on, we could move forward with the rest of the tables. |
|
@atorkmabrains - I sent you an invite to this repository that should let you request review from @proppy |
|
@atorkmabrains - Could you add svg renders of the GDS so they are easy to look at when reviewing / browsing? |
|
@mithro Definitely. |
klayout/drc/rule_decks/main.drc
Outdated
| report("DRC Run Report at", $report) | ||
| else | ||
| logger.info("GF180MCU Klayout DRC runset output at default location." % [File.join(File.dirname(RBA::CellView::active.filename), "gf180_drc.lyrdb")]) | ||
| report("DRC Run Report at", File.join(File.dirname(RBA::CellView::active.filename), "gf180_drc.lyrdb")) |
There was a problem hiding this comment.
I think you might want to save File.join(File.dirname(RBA::CellView::active.filename), "gf180_drc.lyrdb") to an intermediate variable, since it's being used in multiple places in that file.
There was a problem hiding this comment.
something like:
layout_dir = Pathname.new(RBA::CellView::active.filename).parent.realpath
report_path = layout_dir.join("gf180_drc.lyrdb").to_s
logger.info("GF180MCU Klayout DRC runset output at default location: %s" % report_path)
report("DRC Run Report at", report_path)
to ensure that you resolve the path appropriately.
|
@proppy I believe everything has been addressed now. Can we merge this PR? |
|
Here is the report I get when running the combined drc in klayout gui: can you confirm if this is expected? how can I confirm that the failure and pass testcases are detected appropriatly? |
|
@proppy The best way to do this is over a meeting, do you want to have a meeting? Just to give you some hints, you need to look at the |
|
Looks like not all |
|
@proppy what arrows? |
|
The arrow next to each failure case you can see in the svg:
I also don't see them for:
|
|
@proppy These are not important. And they are not necessary for the regression. Some test cases has them, some don't. |
|
@atorkmabrains they are still useful to assert during an highlight that the right cell are supposed to fail, can we log an issue about being consistent here? |
|
@proppy Yes, you could do that using the |
|
added #24 |
|
Additionally the number of error annotations as text in the GDS/SVG seems to be inconsistent with the actual number of highlights in klayout:
|
|
There doesn't seems to be any hightlight for |
|
@proppy I'm not sure how you generated the above report. Could you elaborate? Also, I'm not sure how the count is relevant. |
|
@proppy DV.4 is not a DRC rule as I mentioned before: https://gf180mcu-pdk.readthedocs.io/en/latest/physical_verification/design_manual/drm_07_07.html |
|
@proppy I really need to decouple our |
and then reopening klayout with the gui and editing/running |
Sure, we just need to make sure we document the inconsistency between the number of expected failure case documented in the layout test annotation and the actual drc highlights generated in the db. |
On the |
Filed #25 |
Ok to merge! Really sorry for the long review, but I wanted to take the time to understand all the parts and run the rules myself so that we can more easily review the follow-up PRs adding additional rules. |
|
Thanks @proppy for this review. I'll open the rest of the PRs soon. |
Adding dualgate table rules.
Please note that testcases fail due to klayout build issue:
hdl/conda-eda#282