Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HRES table for GF180MCU DRC #63

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Conversation

FaragElsayed2
Copy link
Collaborator

Adding HRES table for GF180MCU DRC

Fixes #43

@mithro mithro assigned proppy and unassigned proppy Apr 3, 2023
@mithro mithro requested a review from proppy April 3, 2023 17:32
@proppy
Copy link
Member

proppy commented Apr 4, 2023

@atorkmabrains can you review it first?

@atorkmabrains
Copy link
Collaborator

@proppy responded #65

Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# limitations under the License.
################################################################################################

if FEOL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#58 but not blocking


if FEOL
#================================================
#----------------H POLY RESISTOR-----------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#57 but not blocking

logger.info('Executing rule HRES.1')
hres1_l1 = resistor.interacting(hres1_poly).space(0.4.um, euclidian)
hres1_l1.output('HRES.1', 'HRES.1 : Minimum space. Note : Merge if the spacing is less than 0.4 um. : 0.4µm')
hres1_l1.forget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#53 but not blocking


# Rule HRES.7: Minimum Pplus overlap of contact on Poly2 resistor. is 0.2µm
logger.info('Executing rule HRES.7')
hres7_l1 = contact.and(hres_poly).enclosed(pplus, 0.2.um, euclidian).polygons(0.001.um)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have .001 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 1.dbu instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proppy DBU is sensitive to GDS scaling. I prefer real measurement value.

Copy link
Member

@proppy proppy Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but don't we want to smaller possible unit there?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but In some cases were we are measuring corner to corner for example, we have seen that klayout has numerical errors. And it's better to have a slightly larger tolerance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then maybe it's best to define a top level ε variable for this delta so that arithmetic can be done on it (when you need to add or subtract it) and be easier to update if the "numerical errors" conditions happen to change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proppy Each rule might have a different delta. It's not the same for all rules. I thought like you mentioned above, but while running through klayout and testing. We have seen that every type of rule might have a different delta.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment to this: measurements usually are taken in terms of database units (usually nm). Rounding happens to the closer value and is not exactly specified when in between. So if you measure across a diagonal, you may have an exact value like 0.9995 and it will come out as 1000 DBU (assuming a DBU of 1 nm) or 999 DBU which will either give you an error or not.
It is pretty common in any-angle situations that you have to work with some delta. Technically you could implement the check with projection metrics exactly and with a slightly smaller value in Euclidian metrics.

But honestly I think this is nitpicking. Physics is usually in a way that corner-to-corner situations are much different from edge-to-edge ones due to resist or lithography effects and long lines usually behave differently than short edge-to-edge interaction cases. There is no simple mathematical model that describes these cases properly. Every rule you are using is an approximation and so are the check implementations. In practice, DRC checks are made to remind you to take care of potentially critical situations. It's not a good idea to exploit the layout space down to the very limits allowed by DRC (and good layout engineers know that), so whether the check is precise to nanometers or not does not make a difference between a functional and a non-functional chip.

Copy link
Member

@proppy proppy Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each rule might have a different delta

Is that currently the case (I couldn't only find 0.001um delta in the current set of rules) or something that you're predicting?

But honestly I think this is nitpicking

How would you recommend that we maintain those delta?

  • encode them directly it in the rule parameter: with_length(80.00X.um, nil)
  • express them with discrete offset value: with_length(80.001.um + X.dbu, nil)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #67 to discuss this further

# Rule HRES.8: Space from salicide block to contact on Poly2 resistor.
logger.info('Executing rule HRES.8')
hres8_l1 = contact.and(hres_poly).separation(sab,
0.22.um).polygons(0.001.um).or(contact.and(hres_poly).interacting(sab))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have .001 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 1.dbu instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proppy Same comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a workaround for a KLayout bug?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to #65 (comment) this is to convert edges to polygons, I suggested using simple_merge_e2p instead but @atorkmabrains is not sure if this is available in the DRC context.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #66 to investigate this further

logger.info('Executing rule HRES.9')
hres9_sab = sab.interacting(pplus).interacting(res_mk).interacting(resistor)
hres9_clear_sab = hres9_sab.not(hres_poly)
hres9_bad_inside_edge = hres9_sab.edges.inside_part(hres_poly).extended(0, 0, 0.001.um, 0.001.um).interacting(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have .001 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 1.dbu instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added #66

logger.info('Executing rule HRES.10')
pplus1_hres10 = pplus.and(sab).drc(width != 0.1.um)
pplus2_hres10 = pplus.not_overlapping(sab).edges
hres10_l1 = pplus1_hres10.or(pplus2_hres10).extended(0, 0, 0.001.um, 0.001.um).interacting(hres_poly)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have .001 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use 1.dbu instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added #66

hres_poly = poly2.interacting(pplus).interacting(sab).interacting(res_mk).interacting(resistor)
hres1_poly = poly2.interacting(pplus).interacting(sab).interacting(res_mk)

# Rule HRES.1: Minimum space. Note : Merge if the spacing is less than 0.4 um. is 0.4µm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why need to repeat the constraint twice?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

pplus2_hres10.forget

# Rule HRES.11 is not a DRC check
## Please refer to https://gf180mcu-pdk.readthedocs.io/en/latest/physical_verification/design_manual/drm_10_03.html#hres-poly-resistor-phres-optional-with-one-additional-mask
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#55 but not blocking

Copy link
Member

@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits and questions but nothing blocking per se, I'll leave it up to you if you want to address those in this PR or file separate issues to track them.


# Rule HRES.7: Minimum Pplus overlap of contact on Poly2 resistor is 0.2µm.
logger.info('Executing rule HRES.7')
hres7_l1 = contact.and(hres_poly).enclosed(pplus, 0.2.um, euclidian).polygons(0.001.um)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we save contact.and(hres_poly) in an intermediate variable? it seems that it is duplicated below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@proppy proppy merged commit 8248629 into google:main Apr 6, 2023
@atorkmabrains atorkmabrains deleted the hres_google branch April 6, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating PRs for each DRC table separately
4 participants