Adding MIM-B table for GF180MCU DRC #73
Conversation
|
@proppy Could you please merge this? |
|
and sorry for the late review! |
| mimtm11_large_topmin1_metal.data.each do |p| | ||
| mimtm11_topmin1_metal_polygon_layer = polygon_layer | ||
| mimtm11_topmin1_metal_polygon_layer.data.insert(p) | ||
| fuse_in_polygon = fusetop.and(mimtm11_topmin1_metal_polygon_layer) |
There was a problem hiding this comment.
wouldn't it be more effective to test fusetop.and(mimtm11_large_topmin1_metal) outside of a loop, and then look if any resulting shape has an area > 10_000?
There was a problem hiding this comment.
@proppy We have to use all checks inside the loop as we need to iterate over each single plate.
There was a problem hiding this comment.
yes, but is there a difference between:
fuse_in_polygon = fusetop.and(mimtm11_large_topmin1_metal)
fuse_in_polygon_bad = fuse_in_polygon.filter {|p| p > 10_000 }
and what we currently have?
|
|
||
| mimtm11_bad_topmin1_metal_polygon = mimtm11_topmin1_metal_polygon_layer.interacting(fuse_in_polygon) | ||
| mimtm11_bad_topmin1_metal_polygon.data.each do |b| | ||
| b.num_points.positive? && mimtm11_large_topmin1_metal_violation.data.insert(b) |
There was a problem hiding this comment.
what does num_points.positive? check here?
There was a problem hiding this comment.
@proppy It's a sanity check (num_points > 0) to ignore empty polygons.
There was a problem hiding this comment.
wouldn't https://www.klayout.de/doc-qt5/code/class_Polygon.html#method49 also work here?
There was a problem hiding this comment.
@proppy Yes, using !b.is_empty? will get same results.
There was a problem hiding this comment.
should we switch to it? assuming you agree it makes things more readable?
|
@proppy Could you please merge? |
Adding MIM-B table for GF180MCU DRC