Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build native binary in CI (fixes google#894) #1048

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

vorburger
Copy link
Member

Alternative for #1045

Fixes #894

@vorburger vorburger force-pushed the native-with-action-instead-docker branch 2 times, most recently from de50736 to acf07d0 Compare February 10, 2024 12:00
@vorburger
Copy link
Member Author

@cushon voilà! Please review and let's get this to a state where you are happy to merge?

From my side, as-is this only is a first step, to at least start to build the (Linux only, so far) native binary on CI. Building it also for Windows and Mac OS, and then releasing all of them, from my side would be best done in follow-up PRs, once we have this merged, as a basis to then extend and tweak. Could that makes sense to you?

@cushon
Copy link
Collaborator

cushon commented Feb 10, 2024

Thank you for the contribution! Starting with CI and tackling releases as a follow-up SGTM.

I'll plan on merging this after the cleanup changes.

@vorburger vorburger force-pushed the native-with-action-instead-docker branch from acf07d0 to 3c749bd Compare February 11, 2024 11:02
@vorburger vorburger force-pushed the native-with-action-instead-docker branch from 3c749bd to 852553f Compare February 11, 2024 19:52
@vorburger
Copy link
Member Author

Thank you for the contribution! Starting with CI and tackling releases as a follow-up SGTM.

I'll plan on merging this after the cleanup changes.

Cool! FYI I've rebased it just now (since the other changes were just merged)...

@cushon cushon merged commit 3d9c8fa into google:master Feb 11, 2024
9 checks passed
copybara-service bot pushed a commit that referenced this pull request Feb 13, 2024
PiperOrigin-RevId: 606064969
copybara-service bot pushed a commit that referenced this pull request Feb 13, 2024
PiperOrigin-RevId: 606648629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build native image with GraalVM 22.3.0 Java 17 CE
2 participants