Optimze CI to not re-build Eclipse Plugin etc. on GraalVM Native Runner #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cushon
reviewed
Feb 11, 2024
| shell: bash | ||
| run: mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V | ||
| - name: "Test" | ||
| if: ${{ matrix.java != 'GraalVM' }} |
There was a problem hiding this comment.
Skipping these steps for GraalVM sounds good.
I'm realizing that there isn't a lot of overlap between the steps that we want to do for GraalVM and other JDKs--I think all of the steps here happen on other JDKs, or on GraalVM, but not both.
What do you think about adding a separate entry under jobs: for the GraalVM test, isntead of adding it to the matrix with the other JDKs and avoiding all of the checks for java == graal and java != graal?
There was a problem hiding this comment.
FTR: This was done in #1055. (I'll close this PR.)
|
FTR: This was done in #1055, a little differently. I'll therefore close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cushon would this make sense?
Re-building the Eclipse plugins and re-running the tests on GraalVM instead of OpenJDK isn't all that interesting - is it?
Just to make it build slightly faster on CI - and save some 10^-♾️ MW energy for the 🪐 planet!