Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimze CI to not re-build Eclipse Plugin etc. on GraalVM Native Runner #1054

Closed
wants to merge 1 commit into from
Closed

Optimze CI to not re-build Eclipse Plugin etc. on GraalVM Native Runner #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@ jobs:
native-image-job-reports: "true"
cache: "maven"
- name: "Install"
if: ${{ matrix.java != 'GraalVM' }}
shell: bash
run: mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
- name: "Test"
if: ${{ matrix.java != 'GraalVM' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping these steps for GraalVM sounds good.

I'm realizing that there isn't a lot of overlap between the steps that we want to do for GraalVM and other JDKs--I think all of the steps here happen on other JDKs, or on GraalVM, but not both.

What do you think about adding a separate entry under jobs: for the GraalVM test, isntead of adding it to the matrix with the other JDKs and avoiding all of the checks for java == graal and java != graal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: This was done in #1055. (I'll close this PR.)

shell: bash
run: mvn test -B
- name: "Native"
Expand Down
Loading