-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Maven JavaDoc plugin from 3.4.0 to 3.6.3 to fix build failure #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This build](https://github.com/google/google-java-format/actions/runs/7891365432/job/21535541300?pr=1060) for #1060 failed on (only) Windows under GraalVM for Native and I suspect that this change may fix this problem: ``` Error: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.0:jar (attach-javadocs) on project google-java-format: MavenReportException: Error while generating Javadoc: Error: Exit code: 1 - Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\CloseOp.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\CommentsHelper.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Doc.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\DocBuilder.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\FormatterDiagnostic.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\FormattingError.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Indent.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Input.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\InputOutput.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\CommandLineOptions.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\CommandLineOptionsParser.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\DimensionHelpers.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\filer\FormattingFiler.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\filer\FormattingJavaFileObject.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\FormatFileCallable.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Formatter.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\FormatterException.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\GoogleJavaFormatTool.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\GoogleJavaFormatToolProvider.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\ImportOrderer.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\java17\Java17InputAstVisitor.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\java21\Java21InputAstVisitor.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaCommentsHelper.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavacTokens.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\CharStream.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\JavadocFormatter.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\JavadocLexer.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\JavadocWriter.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\NestingCounter.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\javadoc\Token.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaFormatterOptions.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaInput.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaInputAstVisitor.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\JavaOutput.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Main.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\ModifierOrderer.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\RemoveUnusedImports.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Replacement.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\SnippetFormatter.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\StringWrapper.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\Trees.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\TypeNameClassifier.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\UsageException.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Newlines.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Op.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\OpenOp.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\OpsBuilder.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\Output.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\java\com\google\googlejavaformat\java\GoogleJavaFormatVersion.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoOneOf_JavaInputAstVisitor_AnnotationOrModifier.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoValue_FormatFileCallable_Result.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoValue_JavaFormatterOptions.java... Error: Loading source file D:\a\google-java-format\google-java-format\core\target\generated-sources\annotations\com\google\googlejavaformat\java\AutoValue_JavaInputAstVisitor_DeclarationModifiersAndTypeAnnotations.java... Error: Loading source files for package com.google.googlejavaformat... Error: Loading source files for package com.google.googlejavaformat.java... Error: Loading source files for package com.google.googlejavaformat.java.filer... Error: Loading source files for package com.google.googlejavaformat.java.java17... Error: Loading source files for package com.google.googlejavaformat.java.java21... Error: Loading source files for package com.google.googlejavaformat.java.javadoc... Error: Constructing Javadoc information... Error: D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\DimensionHelpers.java:18: error: package com.sun.source.tree is not visible Error: import com.sun.source.tree.AnnotatedTypeTree; Error: ^ Error: (package com.sun.source.tree is declared in module jdk.compiler, but module com.google.googlejavaformat does not read it) Error: D:\a\google-java-format\google-java-format\core\src\main\java\com\google\googlejavaformat\java\DimensionHelpers.java:19: error: package com.sun.source.tree is not visible Error: import com.sun.source.tree.AnnotationTree; (...) ``` @cushon @cpovirk merge? Fixes #1061 COPYBARA_INTEGRATE_REVIEW=#1061 from vorburger:maven-javadoc-plugin c3c4b6f PiperOrigin-RevId: 606705880
copybara-service
bot
force-pushed
the
test_606702907
branch
from
February 13, 2024 20:15
d33bad1
to
59b09fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Maven JavaDoc plugin from 3.4.0 to 3.6.3 to fix build failure
This build for #1060 failed on (only) Windows under GraalVM for Native and I suspect that this change may fix this problem:
@cushon @cpovirk merge?
Fixes #1061
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1061 from vorburger:maven-javadoc-plugin c3c4b6f