-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update opentelemetry to v1.16.0 #14355
Conversation
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14355 +/- ##
=======================================
Coverage 93.06% 93.06%
=======================================
Files 2191 2191
Lines 193212 193212
=======================================
Hits 179821 179821
Misses 13391 13391 ☔ View full report in Codecov by Sentry. |
/gcbrun |
1 similar comment
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we separate these changes to a PR preparing for the update?
auto provider = opentelemetry::sdk::trace::TracerProviderFactory::Create( | ||
std::move(processor)); | ||
std::shared_ptr<opentelemetry::trace::TracerProvider> api_provider = | ||
std::move(provider); | ||
opentelemetry::trace::Provider::SetTracerProvider(std::move(api_provider)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider:
auto provider = opentelemetry::sdk::trace::TracerProviderFactory::Create( | |
std::move(processor)); | |
std::shared_ptr<opentelemetry::trace::TracerProvider> api_provider = | |
std::move(provider); | |
opentelemetry::trace::Provider::SetTracerProvider(std::move(api_provider)); | |
opentelemetry::trace::Provider::SetTracerProvider( | |
std::shared_ptr<opentelemetry::trace::TracerProvider( | |
opentelemetry::sdk::trace::TracerProviderFactory::Create(std::move(processor)))); |
@@ -42,7 +42,7 @@ opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span> StartPublishSpan( | |||
{{sc::kMessagingSystem, "gcp_pubsub"}, | |||
{sc::kMessagingDestinationName, topic.topic_id()}, | |||
{"gcp.project_id", topic.project_id()}, | |||
{sc::kMessagingOperation, "create"}, | |||
{/*sc::kMessagingOperationType=*/"messaging.operation.type", "create"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have this field, since it is no longer a "standard"?
{/*sc::kRpcMessageType=*/"rpc.message.type", "RECEIVED"}, | ||
{/*sc::kRpcMessageId=*/"rpc.message.id", count}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto, if these names are no longer part of the semantic conventions, maybe we should drop them? Or maybe there is a newer name to represent these things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These names are the new hotness. The symbols are not available in the oldest OTel we support (v1.9.1
), so we hardcode their values.
4f7fa03
to
4acfd01
Compare
/gcbrun |
4acfd01
to
b71bc24
Compare
/gcbrun |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
v1.15.0
->v1.16.0
v1.15.0
->v1.16.0
Release Notes
open-telemetry/opentelemetry-cpp (io_opentelemetry_cpp)
v1.16.0
: releaseCompare Source
v1.16.0 release
Release of core packages
and exporter packages:
What's Changed
2022062
.1 to2023080
.2 by @marcalff in https://github.com/open-telemetry/opentelemetry-cpp/pull/2650nostd::enable_if_t
instead ofstd::enable_if_t
by @owent in https://github.com/open-telemetry/opentelemetry-cpp/pull/2648Logger::EmitLogRecord
by @owent in https://github.com/open-telemetry/opentelemetry-cpp/pull/2673third_party_release
by @owent in https://github.com/open-telemetry/opentelemetry-cpp/pull/2677WITH_OTLP_GRPC_SSL_MTLS_PREVIEW
by @owent in https://github.com/open-telemetry/opentelemetry-cpp/pull/2714Important changes
#2664
opentelemetry::trace::Tracer
exposed methods suchas
ForceFlush()
,ForceFlushWithMicroseconds()
,Close()
and
CloseWithMicroseconds()
.and should not be part of the API. Exposing them was an oversight.
OPENTELEMETRY_ABI_VERSION_NO 1
, nothing is changed,because removing this code would break the ABI.
OPENTELEMETRY_ABI_VERSION_NO 2
, these methods are movedfrom the API to the SDK. This is a breaking change for ABI version 2,
which is still experimental.
invoke flush or close on a tracer, do not use these methods.
Breaking changes
#2664
returned an API object (opentelemetry::trace::TracerProvider)
to the caller.
(opentelemetry::sdk::trace::TracerProvider) to the caller.
cleanup and invoke SDK level methods, such as ForceFlush(),
on a provider.
the various provider factories, may need adjustment.
longer perform static_cast do convert an API object to an SDK object.
Please refer to examples for guidance on how to adjust.
an alternate and temporary solution is to build with option
WITH_DEPRECATED_SDK_FACTORY=ON in CMake.
without application changes, posponing changes for later.
an easier migration path. Expect this flag to be removed,
as early as by the next release.
Notes on experimental features
introduced
MeterProvider::SetExemplar()
which accepts anExemplarFilterType
enumeration withkAlwaysOff
,kAlwaysOn
andkTraceBased
.New Contributors
Full Changelog: open-telemetry/opentelemetry-cpp@v1.15.0...v1.16.0
Configuration
📅 Schedule: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.
This change is