Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel): use newer messaging semantic conventions #14373

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 26, 2024

Preparing for opentelemetry-cpp v1.16.0. #14355

They will deprecate some semantic convention types.

In this PR, we adopt the new semantic conventions, but they are not available in the oldest OTel we support, so we must hardcode the values.


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review June 26, 2024 18:58
@dbolduc dbolduc requested review from a team as code owners June 26, 2024 18:58
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (42336db) to head (f922a09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14373   +/-   ##
=======================================
  Coverage   93.06%   93.07%           
=======================================
  Files        2191     2191           
  Lines      193203   193203           
=======================================
+ Hits       179812   179817    +5     
+ Misses      13391    13386    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit 04cad43 into googleapis:main Jun 26, 2024
66 checks passed
@dbolduc dbolduc deleted the prepare-for-otel-1.16.0-sc branch June 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants