Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(GCS+gRPC): skip another integration test #14397

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 28, 2024

This one does not work against production, and it may never work against
production. Disable it until I can get an authoritative answer.

Motivated by #14396


This change is Reviewable

This one does not work against production, and it may never work against
production. Disable it until I can get an authoritative answer.
@coryan coryan force-pushed the test-GCS+gRPC-disable-grpc-notification-test branch from d06ba82 to 156ed1b Compare June 28, 2024 01:51
@coryan coryan marked this pull request as ready for review June 28, 2024 02:20
@coryan coryan requested review from a team as code owners June 28, 2024 02:20
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (748b395) to head (156ed1b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14397      +/-   ##
==========================================
+ Coverage   93.07%   93.56%   +0.49%     
==========================================
  Files        2191     2280      +89     
  Lines      193293   204287   +10994     
==========================================
+ Hits       179899   191133   +11234     
+ Misses      13394    13154     -240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit ce3e02e into googleapis:main Jun 28, 2024
66 checks passed
@coryan coryan deleted the test-GCS+gRPC-disable-grpc-notification-test branch June 28, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants