impl(bigquerycontrol): promote from experimental to transitional #14887

scotthart · 2024-12-09T17:22:00Z

This change is

codecov · 2024-12-09T17:46:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (6b60e33) to head (f767cf5).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14887   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files        2351     2351           
  Lines      209692   209692           
=======================================
+ Hits       194832   194841    +9     
+ Misses      14860    14851    -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbolduc

This is probably a convenient way to keep defining the experimental-* target, which quickstart-cmake-pr needs.

https://github.com/coryan/google-cloud-cpp/blob/49b7952a640dd4e323b2acafe18088557ff8f3a7/google/cloud/accessapproval/config.cmake.in#L23-L26

google/cloud/bigquerycontrol/README.md

scotthart

So the edits to the config.cmake.in fixed one issue, but because the quickstart-cmake build uses the current release and not HEAD to install cmake targets, the build could not find experimental-bigquerycontrol, so I have temporarily excluded it from that build.

Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @dbolduc)

google/cloud/bigquerycontrol/README.md

dbolduc · 2024-12-11T16:28:08Z

google/cloud/bigquerycontrol/quickstart/BUILD.bazel

@@ -20,6 +20,6 @@ cc_binary(
        "quickstart.cc",
    ],
    deps = [
-        "@google_cloud_cpp//:experimental-bigquerycontrol",


I don't think we should be changing the quickstart targets just yet

https://github.com/googleapis/google-cloud-cpp/blob/main/doc/contributor/howto-guide-declare-a-library-ga.md#reference-the-ga-targets-in-the-quickstarts

dbolduc · 2024-12-11T16:28:17Z

google/cloud/bigquerycontrol/quickstart/CMakeLists.txt

@@ -29,4 +29,4 @@ endif ()

 # Define your targets.
 add_executable(quickstart quickstart.cc)
-target_link_libraries(quickstart google-cloud-cpp::experimental-bigquerycontrol)
+target_link_libraries(quickstart google-cloud-cpp::bigquerycontrol)


scotthart

Reviewable status: 0 of 16 files reviewed, 3 unresolved discussions (waiting on @dbolduc)

scotthart · 2024-12-11T17:19:20Z

google/cloud/bigquerycontrol/quickstart/BUILD.bazel

@@ -20,6 +20,6 @@ cc_binary(
        "quickstart.cc",
    ],
    deps = [
-        "@google_cloud_cpp//:experimental-bigquerycontrol",


scotthart · 2024-12-11T17:19:21Z

google/cloud/bigquerycontrol/quickstart/CMakeLists.txt

@@ -29,4 +29,4 @@ endif ()

 # Define your targets.
 add_executable(quickstart quickstart.cc)
-target_link_libraries(quickstart google-cloud-cpp::experimental-bigquerycontrol)
+target_link_libraries(quickstart google-cloud-cpp::bigquerycontrol)


dbolduc · 2024-12-11T17:22:14Z

google/cloud/bigquerycontrol/CMakeLists.txt

-    bigquerycontrol "Cloud BigQuery Control API" EXPERIMENTAL REST_TRANSPORT
-    SERVICE_DIRS "v2/")
+google_cloud_cpp_add_gapic_library(bigquerycontrol "Cloud BigQuery Control API"
+                                   REST_TRANSPORT SERVICE_DIRS "v2/")


We want a TRANSITION flag here

dbolduc · 2024-12-11T17:22:57Z

google/cloud/spanner/samples/samples.cc

@@ -1747,7 +1747,7 @@ void RestoreDatabaseWithEncryptionKeyCommand(std::vector<std::string> argv) {
 // [START spanner_restore_backup_with_MR_CMEK]
 void RestoreDatabaseWithMRCMEK(
    google::cloud::spanner_admin::DatabaseAdminClient client,
-    BackupIdentifier src, std::string const& database_id,
+    BackupIdentifier const& src, std::string const& database_id,


odd that we are making a spanner change in this PR, but it looks like a good change

For reasons unknown, clang-tidy complained about it in this PR, not whichever PR is was introduced in.

scotthart

Reviewable status: 0 of 16 files reviewed, 5 unresolved discussions (waiting on @dbolduc)

scotthart · 2024-12-11T17:28:04Z

google/cloud/spanner/samples/samples.cc

@@ -1747,7 +1747,7 @@ void RestoreDatabaseWithEncryptionKeyCommand(std::vector<std::string> argv) {
 // [START spanner_restore_backup_with_MR_CMEK]
 void RestoreDatabaseWithMRCMEK(
    google::cloud::spanner_admin::DatabaseAdminClient client,
-    BackupIdentifier src, std::string const& database_id,
+    BackupIdentifier const& src, std::string const& database_id,


For reasons unknown, clang-tidy complained about it in this PR, not whichever PR is was introduced in.

scotthart requested a review from a team as a code owner December 9, 2024 17:22

scotthart temporarily deployed to false December 9, 2024 17:22 — with GitHub Actions Inactive

dbolduc reviewed Dec 9, 2024

View reviewed changes

google/cloud/bigquerycontrol/README.md Show resolved Hide resolved

scotthart temporarily deployed to false December 10, 2024 16:40 — with GitHub Actions Inactive

scotthart commented Dec 10, 2024

View reviewed changes

google/cloud/bigquerycontrol/README.md Show resolved Hide resolved

scotthart force-pushed the bigquery_control_transitional branch from 13059dd to fa4f7d7 Compare December 10, 2024 22:04

scotthart temporarily deployed to false December 10, 2024 22:05 — with GitHub Actions Inactive

scotthart temporarily deployed to false December 11, 2024 01:30 — with GitHub Actions Inactive

dbolduc reviewed Dec 11, 2024

View reviewed changes

scotthart force-pushed the bigquery_control_transitional branch from b06f21f to 1442db1 Compare December 11, 2024 17:06

scotthart temporarily deployed to false December 11, 2024 17:07 — with GitHub Actions Inactive

impl(bigquerycontrol): promote from experimental to transitional

00b4d4a

scotthart force-pushed the bigquery_control_transitional branch from 1442db1 to 00b4d4a Compare December 11, 2024 17:09

scotthart temporarily deployed to false December 11, 2024 17:09 — with GitHub Actions Inactive

use experimental target in quickstarts for now

cadf39c

scotthart commented Dec 11, 2024

View reviewed changes

scotthart temporarily deployed to false December 11, 2024 17:19 — with GitHub Actions Inactive

dbolduc reviewed Dec 11, 2024

View reviewed changes

scotthart commented Dec 11, 2024

View reviewed changes

added TRANSITION

f767cf5

scotthart temporarily deployed to false December 11, 2024 17:30 — with GitHub Actions Inactive

dbolduc approved these changes Dec 11, 2024

View reviewed changes

scotthart merged commit e2ed1e6 into googleapis:main Dec 11, 2024
74 of 75 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

impl(bigquerycontrol): promote from experimental to transitional #14887

impl(bigquerycontrol): promote from experimental to transitional #14887

scotthart commented Dec 9, 2024 •

edited

Loading

codecov bot commented Dec 9, 2024 •

edited

Loading

dbolduc left a comment

scotthart left a comment

dbolduc Dec 11, 2024

scotthart Dec 11, 2024

dbolduc Dec 11, 2024

scotthart Dec 11, 2024

scotthart left a comment

scotthart Dec 11, 2024

scotthart Dec 11, 2024

dbolduc Dec 11, 2024

dbolduc Dec 11, 2024

scotthart Dec 11, 2024

scotthart left a comment

scotthart Dec 11, 2024

impl(bigquerycontrol): promote from experimental to transitional #14887

impl(bigquerycontrol): promote from experimental to transitional #14887

Conversation

scotthart commented Dec 9, 2024 • edited Loading

codecov bot commented Dec 9, 2024 • edited Loading

Codecov Report

dbolduc left a comment

Choose a reason for hiding this comment

scotthart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scotthart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scotthart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scotthart commented Dec 9, 2024 •

edited

Loading

codecov bot commented Dec 9, 2024 •

edited

Loading