Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust release-please configs for cloudbuild yaml updates #2351

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mpeddada1
Copy link
Contributor

Following the Update arbitrary yaml file strategy is resulting in release-please making unexpected changes to the cloudbuild yaml files. See #2350.

Modifying release-please configs to follow Update arbitrary file strategy combined with inline annotations as described in https://github.com/googleapis/release-please/blob/main/docs/customizing.md#updating-arbitrary-files:
Screenshot 2024-01-09 at 1 19 08 PM

@mpeddada1 mpeddada1 requested a review from a team as a code owner January 9, 2024 18:20
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 9, 2024
@burkedavison
Copy link
Member

Should there be associated x-release-please-version comments added to the cloudbuild files, as mentioned in the screenshot for this PR?

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mpeddada1
Copy link
Contributor Author

Should there be associated x-release-please-version comments added to the cloudbuild files, as mentioned in the screenshot for this PR?

Hmm yeah was thinking about this too. We have the x-version-update annotation which is slightly different from the ones listed in the readme but is the convention in most our repos including java-shared-config (which uses it to update the cloudbuild yaml files) so was curious to try this out as an initial attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants