fauntlet - the font gauntlet #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drott
reviewed
Oct 31, 2023
- move FreeType and Skrifa specific code into own modules - move compare_glyphs() function from bin to lib - add tests for RegularizingPen cases
drott
approved these changes
Nov 6, 2023
|
Thanks for following up. I meant to mark those review items as done but got caught up on the lsb diffs :) Before merging, I have one more update to this to clean up FT advances (as well as a patch to fontations to fix a couple issues). |
- use linearHoriAdvance from glyph slot for FT advances (requires FT_LOAD_LINEAR_DESIGN in unscaled case) - skip fonts that FT believes are not scalable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the elusive tool for comparing output between freetype and skrifa.
There are lots of potential improvements (things I have in mind are "fuzzing" instance parameters as well as support for benchmarking) but I've tried to keep the initial version simple. It does use mmap for reading font files and rayon to process them in parallel as comparisons on large font sets can be quite slow.
@drott your feedback on this would be appreciated. The README (rendered) contains an explicit list of output differences which might be useful. The
RegularizingPentype inpen.rshas the code that handles this.