Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDocs for activity files #101

Merged
merged 12 commits into from
Aug 8, 2020
Merged

JSDocs for activity files #101

merged 12 commits into from
Aug 8, 2020

Conversation

anan-ya-y
Copy link
Collaborator

@anan-ya-y anan-ya-y commented Jul 24, 2020

What is a quick description of the change?

Write properly formatted jsdocs.

Is this fixing an issue?

Addresses #94

Are there more details that are relevant?

This PR also modifies some syntax. No functional changes.

Check lists (check x in [ ] of list items)

  • [ ] Test written/updating
  • [ ] Tests passing
  • [ ] Coding style (indentation, etc)

Please explain why any are not present, if any.
no need, these are jsdocs.

Any additional comments?

Base automatically changed from activity-issue85 to master July 29, 2020 23:24
@anan-ya-y anan-ya-y self-assigned this Aug 4, 2020
@anan-ya-y anan-ya-y requested review from keiffer01 and zghera and removed request for keiffer01 August 4, 2020 16:31
frontend/src/components/Utils/time.js Outdated Show resolved Hide resolved
frontend/src/components/Utils/time.js Outdated Show resolved Hide resolved
frontend/src/components/Utils/time.js Outdated Show resolved Hide resolved
frontend/src/components/Utils/time.js Outdated Show resolved Hide resolved
frontend/src/components/Utils/time.js Outdated Show resolved Hide resolved
frontend/src/components/ViewActivities/index.js Outdated Show resolved Hide resolved
frontend/src/components/ViewActivities/index.js Outdated Show resolved Hide resolved
@anan-ya-y anan-ya-y requested a review from zghera August 7, 2020 18:16
@zghera zghera mentioned this pull request Aug 7, 2020
2 tasks
frontend/src/components/ViewActivities/activitylist.js Outdated Show resolved Hide resolved
frontend/src/components/ViewActivities/editActivity.js Outdated Show resolved Hide resolved
frontend/src/components/ViewActivities/editActivity.js Outdated Show resolved Hide resolved
@anan-ya-y anan-ya-y marked this pull request as ready for review August 7, 2020 22:18
@anan-ya-y
Copy link
Collaborator Author

Received @Hiram-Silvey 's verbal approval to merge since this is the last day of the internship and he was not able to review the PR.

@anan-ya-y anan-ya-y merged commit 5d471e1 into master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants