feat: add policy tags and masking policy support for maxcompute #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayurjag
force-pushed
the
feat/maxcompute-policy-tags-masking-policy
branch
from
0f32b34 to
b06064e
Compare
Mayurjag
force-pushed
the
feat/maxcompute-policy-tags-masking-policy
branch
4 times, most recently
from
6a95ac6 to
e7d694c
Compare
There was a problem hiding this comment.
PR Overview
This PR adds support for masking policies and policy tags in maxcompute, enhancing both the client functionality and corresponding mocks used in testing.
- Added GetMaskingPolicy support in the maxcompute client and its corresponding mocks.
- Updated extractor functions to integrate the new masking policy.
- Upgraded artifact upload actions in the CI workflow.
Reviewed Changes
| File | Description |
|---|---|
| plugins/extractors/maxcompute/mocks/maxcompute_client_mock.go | Added mock methods for GetMaskingPolicy to support testing needs. |
| plugins/extractors/maxcompute/maxcompute.go | Updated extractor to pass the required table parameter and integrate masking policy. |
| plugins/extractors/maxcompute/client/client.go | Implemented GetMaskingPolicy to retrieve masking policies from a table. |
| .github/workflows/test.yml | Updated artifact upload actions from v3 to v4. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
haveiss
reviewed
Mar 4, 2025
irainia
requested changes
Mar 10, 2025
Mayurjag
force-pushed
the
feat/maxcompute-policy-tags-masking-policy
branch
from
477bb8e to
abf270b
Compare
irainia
approved these changes
Mar 12, 2025
haveiss
reviewed
Mar 13, 2025
Mayurjag
force-pushed
the
feat/maxcompute-policy-tags-masking-policy
branch
from
abf270b to
3c4e5c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.