Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add policy tags and masking policy support for maxcompute #78

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add policy tags and masking policy support for maxcompute #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2e4f47
feat: add policy tags and masking policy support for maxcompute
solsticemj25 Jan 22, 2025
c99e145
fix: update version of actions/upload-artifact
solsticemj25 Mar 3, 2025
367655a
feat: changed approach and cleaned code
solsticemj25 Mar 4, 2025
3c4e5c0
feat: refactored tests by adding masking policy
solsticemj25 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions plugins/extractors/maxcompute/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,23 @@ func (c *Client) GetTablePreview(_ context.Context, partitionValue string, table

return columnNames, protoList, nil
}

func (*Client) GetMaskingPolicies(table *odps.Table) (maskingPolicies []string, err error) {
columnMaskInfos, err := table.ColumnMaskInfos()
if err != nil {
return nil, err
}

policySet := make(map[string]struct{})
for _, columnMaskInfo := range columnMaskInfos {
for _, policyName := range columnMaskInfo.PolicyNameList {
policySet[policyName] = struct{}{}
}
}

for policyName := range policySet {
maskingPolicies = append(maskingPolicies, policyName)
}

return maskingPolicies, nil
}
15 changes: 13 additions & 2 deletions plugins/extractors/maxcompute/maxcompute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ type Client interface {
ListTable(ctx context.Context, schemaName string) ([]*odps.Table, error)
GetTableSchema(ctx context.Context, table *odps.Table) (string, *tableschema.TableSchema, error)
GetTablePreview(ctx context.Context, partitionValue string, table *odps.Table, maxRows int) ([]string, *structpb.ListValue, error)
GetMaskingPolicies(table *odps.Table) ([]string, error)
}

func New(logger log.Logger, clientFunc NewClientFunc, randFn randFn) *Extractor {
Expand Down Expand Up @@ -212,7 +213,7 @@ func (e *Extractor) buildAsset(ctx context.Context, schema *odps.Schema,
Service: maxcomputeService,
}

tableAttributesData := e.buildTableAttributesData(schemaName, tableType, tableSchema)
tableAttributesData := e.buildTableAttributesData(schemaName, tableType, table, tableSchema)

if tableType == config.TableTypeView {
query := tableSchema.ViewText
Expand Down Expand Up @@ -298,7 +299,7 @@ func buildColumns(dataType datatype.DataType) []*v1beta2.Column {
return columns
}

func (e *Extractor) buildTableAttributesData(schemaName, tableType string, tableInfo *tableschema.TableSchema) map[string]interface{} {
func (e *Extractor) buildTableAttributesData(schemaName, tableType string, table *odps.Table, tableInfo *tableschema.TableSchema) map[string]interface{} {
attributesData := map[string]interface{}{}

attributesData["project_name"] = e.config.ProjectName
Expand All @@ -321,6 +322,16 @@ func (e *Extractor) buildTableAttributesData(schemaName, tableType string, table
attributesData["partition_fields"] = partitionNames
}

maskingPolicy, err := e.client.GetMaskingPolicies(table)
if err != nil {
e.logger.Warn("error getting masking policy", "error", err)
}
maskingPolicyInterface := make([]interface{}, len(maskingPolicy))
for i, policy := range maskingPolicy {
maskingPolicyInterface[i] = policy
}
attributesData["masking_policy"] = maskingPolicyInterface

return attributesData
}

Expand Down
3 changes: 3 additions & 0 deletions plugins/extractors/maxcompute/maxcompute_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ func TestExtract(t *testing.T) {
},
nil,
)
mockClient.EXPECT().GetMaskingPolicies(mock.Anything).Return([]string{"policyTag1", "policyTag2", "policyTag3"}, nil)
}, nil)

assert.Nil(t, err)
Expand Down Expand Up @@ -266,6 +267,7 @@ func TestExtract(t *testing.T) {
},
nil,
)
mockClient.EXPECT().GetMaskingPolicies(mock.Anything).Return([]string{}, nil)
}, nil)

assert.Nil(t, err)
Expand All @@ -291,6 +293,7 @@ func TestExtract(t *testing.T) {
mockClient.EXPECT().ListSchema(mock.Anything).Return(schema1, nil)
mockClient.EXPECT().ListTable(mock.Anything, "my_schema").Return(table1[1:], nil)
mockClient.EXPECT().GetTableSchema(mock.Anything, table1[1]).Return("MANAGED_TABLE", schemaMapping[table1[1].Name()], nil)
mockClient.EXPECT().GetMaskingPolicies(mock.Anything).Return([]string{}, nil)
}, nil)

assert.Nil(t, err)
Expand Down
58 changes: 58 additions & 0 deletions plugins/extractors/maxcompute/mocks/maxcompute_client_mock.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions plugins/extractors/maxcompute/testdata/expected-assets-with-table-exclusion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"preview_fields": [],
"preview_rows": null,
"attributes": {
"masking_policy": [],
"project_name": "test-project-id",
"resource_url": "/projects/test-project-id/schemas/my_schema/tables/new_table",
"schema": "my_schema",
Expand Down
2 changes: 2 additions & 0 deletions plugins/extractors/maxcompute/testdata/expected-assets-with-view-lineage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"preview_fields": [],
"preview_rows": null,
"attributes": {
"masking_policy": [],
"project_name": "test-project-id",
"resource_url": "/projects/test-project-id/schemas/my_schema/tables/dummy_table",
"schema": "my_schema",
Expand Down Expand Up @@ -128,6 +129,7 @@
]
],
"attributes": {
"masking_policy": [],
"project_name": "test-project-id",
"resource_url": "/projects/test-project-id/schemas/my_schema/tables/new_table",
"schema": "my_schema",
Expand Down
10 changes: 10 additions & 0 deletions plugins/extractors/maxcompute/testdata/expected-assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@
"preview_fields": [],
"preview_rows": null,
"attributes": {
"masking_policy": [
"policyTag1",
"policyTag2",
"policyTag3"
],
"project_name": "test-project-id",
"resource_url": "/projects/test-project-id/schemas/my_schema/tables/dummy_table",
"schema": "my_schema",
Expand Down Expand Up @@ -118,6 +123,11 @@
]
],
"attributes": {
"masking_policy": [
"policyTag1",
"policyTag2",
"policyTag3"
],
"project_name": "test-project-id",
"resource_url": "/projects/test-project-id/schemas/my_schema/tables/new_table",
"schema": "my_schema",
Expand Down