Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check mode for grafana role #125

Conversation

Boschung-Mecatronic-AG-Infrastructure
Copy link
Contributor

The current main code does not support --check mode.
It does errors:

TASK [grafana.grafana.grafana : Import grafana dashboards] *********************
fatal: [host]: FAILED! => {"msg": "'dict object' has no attribute 'path'. 'dict object' has no attribute 'path'"}
TASK [grafana.grafana.grafana : Remove dashboards not present on deployer machine (synchronize)] ***
fatal: [host]: FAILED! => {"msg": "Invalid data passed to 'loop', it requires a list, got this instead: set(). Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup."}

Proposed modifications make --check option running smoothly without any errors.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@ishanjainn ishanjainn merged commit b8adf19 into grafana:main Dec 5, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants